Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Feb 2013 16:32:37 +0000 (UTC)
From:      Andrew Gallatin <gallatin@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r247470 - stable/9/sys/netinet
Message-ID:  <201302281632.r1SGWbTn062462@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gallatin
Date: Thu Feb 28 16:32:36 2013
New Revision: 247470
URL: http://svnweb.freebsd.org/changeset/base/247470

Log:
  MFC r247104:
    Fix tcp_lro_rx_ipv4() for drivers that do not set CSUM_IP_CHECKED.
    Specifcially, in_cksum_hdr() returns 0 (not 0xffff) when the IPv4
    checksum is correct. Without this fix, the tcp_lro code will reject
    good IPv4 traffic from drivers that do not implement IPv4 header
    harder csum offload.

Modified:
  stable/9/sys/netinet/tcp_lro.c
Directory Properties:
  stable/9/sys/   (props changed)

Modified: stable/9/sys/netinet/tcp_lro.c
==============================================================================
--- stable/9/sys/netinet/tcp_lro.c	Thu Feb 28 16:32:25 2013	(r247469)
+++ stable/9/sys/netinet/tcp_lro.c	Thu Feb 28 16:32:36 2013	(r247470)
@@ -333,7 +333,7 @@ tcp_lro_rx_ipv4(struct lro_ctrl *lc, str
 		}
 	} else {
 		csum = in_cksum_hdr(ip4);
-		if (__predict_false((csum ^ 0xffff) != 0)) {
+		if (__predict_false((csum) != 0)) {
 			lc->lro_bad_csum++;
 			return (TCP_LRO_CANNOT);
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302281632.r1SGWbTn062462>