Date: Wed, 11 Jan 2012 11:12:37 -0500 From: Greg Larkin <glarkin@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: Michael Scheidell <scheidell@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Gabor Kovesdan <gabor@FreeBSD.org>, raven428@gmail.com, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc Message-ID: <4F0DB4F5.7020906@FreeBSD.org> In-Reply-To: <4F0CC4DF.6030906@FreeBSD.org> References: <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org> <4F0CC4DF.6030906@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 1/10/12 6:08 PM, Doug Barton wrote:
> On 01/10/2012 04:26, Gabor Kovesdan wrote:
>> Em 10-01-2012 09:42, Doug Barton escreveu:
>>> Can you fix this using WITH_MYSQL_VER= 52 please? The way that you're
>>> using MYSQL_PORTDIR isn't going to work. Take a look at
>>> ports/Mk/bsd.databases.mk for more information on how to properly
>>> specify dependencies for mysql ports.
>>>
>>> Also, FYI, we no longer have 323 or 40 in the tree.
>> I have checked this and actually it seems USE_MYSQL can be limited to
>> server and 323 and 40 can be removed as you say. However, the port
>> directory trick was not introduced by Michael and afaik the port worked
>> before. Or just nobody complained. The problem here is that the build
>> requires the MySQL server source and you cannot do that with
>> BUILD_DEPENDS, so the usual framework features do not work here.
>
> It was glarkin that introduced the bogus MYSQL_PORTDIR definition
> originally. But it was the addition of this:
>
> ${NONEXISTENT}:${MYSQL_PORTDIR}:configure \
>
> in version 1.3 (by Michael, not in the PR) that is causing my INDEX
> build to create errors, since /usr/ports/databases/mysql52-server
> doesn't exist.
>
> I'm not sure why portindex hates that line more than it hated the
> already bogus line above it, but it does. I'm also not sure how a 3-part
> build dep could be valid, but I'm not up to speed on all the latest
> tricks there.
>
> The correct fix is probably to remove that line and add something like
> (untested):
>
> .if ${MYSQL_VER} == 52
> MYSQL_PORTDIR= ${PORTSDIR}/databases/mariadb-server
> .else
> MYSQL_PORTDIR= ${PORTSDIR}/databases/mysql${MYSQL_VER}-server
> .endif
>
> That should allow it to work with mariadb.
>
>
> hth,
>
> Doug
>
Hi Doug,
The line "${NONEXISTENT}:${MYSQL_PORTDIR}:configure" has been there
since the initial import, and the ":configure" portion adheres to the
description here:
http://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#AEN2138.
Can you post the errors from the INDEX build?
The idea is that we want to extract the MySQL server source and execute
the configure target before starting the pinba_engine build. Pinba
needs the MySQL include/my_config.h file present to build. At least the
Makefile should check for the presence of MYSQL_PORTDIR before doing
anything.
Since Pinba now supports MySQL 5.1.x+ and MariaDB 5.1.43+, the better
solution may be to present options to the user to select the database
backend, adjust DISTFILES accordingly and configure the database sources
in the local WRKSRC.
Check line 81 and one for the way we did something similar to build the
Java frontend to gcc:
http://www.freebsd.org/cgi/cvsweb.cgi/ports/lang/gcc42/Makefile?annotate=1.355
Let me know what you think,
Greg
- --
Greg Larkin
http://www.FreeBSD.org/ - The Power To Serve
http://www.sourcehosting.net/ - Ready. Set. Code.
http://twitter.com/cpucycle/ - Follow you, follow me
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk8NtPUACgkQ0sRouByUApCJOwCferkD+El7iZMPhAYHjjpMXADi
uKMAnRhXZfIaryuunHAEh9qV4U3taZxK
=JGb0
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0DB4F5.7020906>