Date: Tue, 11 Oct 2022 09:04:30 -0600 From: Warner Losh <imp@bsdimp.com> To: Tom Jones <thj@freebsd.org> Cc: Jessica Clarke <jrtc27@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 67f2a563bfca - main - acpi: Tell SMM we will handle CPPC notifications Message-ID: <CANCZdfp_Wi4OLnn3SAQTZTV2UMGeFz3VgCJpz_Bjd4nG%2B20p8g@mail.gmail.com> In-Reply-To: <Y0V%2Bhd0P77V93e3m@spacemonster> References: <202210101353.29ADrhXG012590@gitrepo.freebsd.org> <2963DD27-E730-445D-BD59-0DB728CDA203@freebsd.org> <Y0UqXmrT%2B3OT4xfD@spacemonster> <CANCZdfp_7YsKac-i7YC0osWPEK4HSo9EHQNECd-m_VNddm3CFw@mail.gmail.com> <Y0V%2Bhd0P77V93e3m@spacemonster>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Oct 11, 2022 at 8:32 AM Tom Jones <thj@freebsd.org> wrote: > On Tue, Oct 11, 2022 at 07:32:47AM -0600, Warner Losh wrote: > > On Tue, Oct 11, 2022 at 2:33 AM Tom Jones <thj@freebsd.org> wrote: > > > > > > > > > > This isn’t under an ifdef? > > > > > > > > Jess > > > > > > > > > > It should be, thanks for pointing it out. I've fixed it now. > > > > > > I hope when we get support for CPPC on arm64 we don't have this sort of > > > issue too. > > > > > > > Is CPPC missing completely? IF so, then ignore the suggestion I made on > the > > #ifdef. > > I am not aware that we have support, a quick google didn't show anything > up. Linux does have support, the initial review I found looked like > quite a bit of work. > > If no one shouts I am going to leave this for now, we can always expand > scope in the future. > OK. In that case, you need to ifdef the > +static bool cppc_notify; line, otherwise many compilers will complain that it's not used on !x86 Warner > - Tom > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 11, 2022 at 8:32 AM Tom Jones <<a href="mailto:thj@freebsd.org">thj@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Oct 11, 2022 at 07:32:47AM -0600, Warner Losh wrote:<br> > On Tue, Oct 11, 2022 at 2:33 AM Tom Jones <<a href="mailto:thj@freebsd.org" target="_blank">thj@freebsd.org</a>> wrote:<br> > <br> > > ><br> > > > This isn’t under an ifdef?<br> > > ><br> > > > Jess<br> > > ><br> > ><br> > > It should be, thanks for pointing it out. I've fixed it now.<br> > ><br> > > I hope when we get support for CPPC on arm64 we don't have this sort of<br> > > issue too.<br> > ><br> > <br> > Is CPPC missing completely? IF so, then ignore the suggestion I made on the<br> > #ifdef.<br> <br> I am not aware that we have support, a quick google didn't show anything<br> up. Linux does have support, the initial review I found looked like<br> quite a bit of work.<br> <br> If no one shouts I am going to leave this for now, we can always expand<br> scope in the future.<br></blockquote><div><br></div><div>OK. In that case, you need to ifdef the </div><div>> +static bool cppc_notify;<br></div><div>line, otherwise many compilers will complain that it's not used on !x86</div><div><br></div><div>Warner</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> - Tom<br> </blockquote></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp_Wi4OLnn3SAQTZTV2UMGeFz3VgCJpz_Bjd4nG%2B20p8g>