Date: Wed, 16 Dec 2009 00:47:05 -0500 From: Toby Burress <kurin@delete.org> To: Tom Rhodes <trhodes@FreeBSD.org> Cc: freebsd-doc@FreeBSD.org Subject: Re: ldap-auth article patch Message-ID: <20091216054705.GB3748@lithium.delete.org> In-Reply-To: <20091110012610.GH67127@lithium.delete.org> References: <20091109184326.GG67127@lithium.delete.org> <20091109193952.1b8f790e.trhodes@FreeBSD.org> <20091110012610.GH67127@lithium.delete.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Resending this, as I guess it didn't make the list. On Mon, Nov 09, 2009 at 08:26:10PM -0500, Toby Burress wrote: > On Mon, Nov 09, 2009 at 07:39:52PM -0500, Tom Rhodes wrote: > > Patch modified, please verify the original meaning by giving > > my version a once over. > > It looks like this was modified from my original ticket instead of > the second patch I sent. Either one is fine (they both catch the > dimins.com -> example.org stuff, and yours additionally expands > contractions). However, in your patch there are two parenthetical > statements which aren't closed. > > 107c107 > < +# binds, there's probably some standard account you use for this. > --- > > +# binds, there's probably some standard account you use for this). > 112c112 > < +# UID elsewhere in the tree; we don't want to return those. > --- > > +# UID elsewhere in the tree; we don't want to return those). > 158a159 > > Other than that it looks fine.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091216054705.GB3748>