Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jan 2024 11:06:27 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Gleb Popov <arrowd@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: d2e99e0393d6 - main - games/yadex: install the manpage under $PREFIX/share/man.
Message-ID:  <Za5MM4Iq5YFAkp5D@FreeBSD.org>
In-Reply-To: <CALH631n1RA6g90bBB_m3AqznQNJ8xyxEe8MP3qRhx1vOeOAjjw@mail.gmail.com>
References:  <202401220839.40M8dXYO009970@gitrepo.freebsd.org> <CALH631k2_Dw4n9a-eT8fNhf3BWHvPFpAKzZCCAFWfLm=sXkH3w@mail.gmail.com> <Za4uSwt9hMAbMEMu@FreeBSD.org> <CALH631np9RR0pq_9n3FRoXkxe0douQbpJJ3iGR-r%2BTGLcm-SAA@mail.gmail.com> <Za44NHtbyGzX2xAa@FreeBSD.org> <CALH631kk7Jqwt1_8xUjLVBrTQ67riDws=ajU8%2BfFvaYkcfV2tg@mail.gmail.com> <Za49mylJgNTt6xZp@FreeBSD.org> <CALH631nxx7y0aWzWNcXe3gr28g92s7d80Mp1Qb-GomGaYXKr9Q@mail.gmail.com> <Za5D2w0Y2gGhhaqG@FreeBSD.org> <CALH631n1RA6g90bBB_m3AqznQNJ8xyxEe8MP3qRhx1vOeOAjjw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 22, 2024 at 01:46:21PM +0300, Gleb Popov wrote:
> On Mon, Jan 22, 2024 at 1:30???PM Alexey Dokuchaev wrote:
> > Not sure I understand: to change default GNU_CONFIGURE_MANPREFIX you'd
> > either have to fix all ports first (one by one, or better in small
> > groups, e.g. per-category or per-maintainer), then flip the switch and
> > drop custom GNU_CONFIGURE_MANPREFIX in individual ports (or skip/delay
> > the drop because they would be redundant, but harmless), no?  You want
> > to change everything in one big commit?  While I love to group commits,
> > that would be a little *too* big, I reckon.
> 
> It is not about commit squashing.

I didn't imply or mention commit squashing.

> The problem can be solved incrementally but it introduces more churn
> in the repository:
> 
> 1. We go over all affected ports plugging GNU_CONFIGURE_MANPREFIX
> knobs into them.

Right, this is phase one, and that's where we're now.

> 2. Flip the switch in bsd.port.mk
> 3. Remove now useless GNU_CONFIGURE_MANPREFIX knobs from all the ports
> again.

Yeah, that's identical to what I described above (quoted text) as method
#1 vs. one huge commit (#2).  Where is the extra churn?  Or you propose
something other than these 1-2-3 steps?  I still don't follow... :-/

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Za5MM4Iq5YFAkp5D>