Date: Sun, 24 Aug 2008 15:20:44 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/syscons sysmouse.c Message-ID: <200808241520.m7OFKma1013024@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2008-08-24 15:20:44 UTC
FreeBSD src repository
Modified files:
sys/dev/syscons sysmouse.c
Log:
SVN rev 182109 on 2008-08-24 15:20:44Z by ed
Make sysmouse(4) use its own locks, instead of using Giant.
When I changed syscons(4) to work with the MPSAFE TTY code, I just
locked all device nodes down using the compatibility feature that allows
you to override the TTY's lock (Giant in this case). Upon closer
inspection, it seems sysmouse(4) only has two internal variables that
need locking: mouse_level and mouse_status.
I haven't done any performance benchmarks on this, though I think it
won't have any dramatic improvements on the system. It is good to get
rid of Giant here, because the third argument of tty_alloc() has only
been added to ease migration to MPSAFE TTY. It should not be used when
not needed.
While there, remove SC_MOUSE, which is a leftover from the MPSAFE TTY
import.
Revision Changes Path
1.32 +10 -14 src/sys/dev/syscons/sysmouse.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808241520.m7OFKma1013024>