Date: Sun, 28 Jul 2013 21:30:24 +0300 From: George Liaskos <geo.liaskos@gmail.com> To: =?UTF-8?Q?Ren=C3=A9_Ladan?= <rene@freebsd.org> Cc: freebsd-chromium@freebsd.org Subject: Re: compiling Chromium 28 with clang33 fixes "unclickable" links Message-ID: <CANcjpODpL8z=f7xriGjNFbXh5PfgQx000S%2BqU9qmhy2fkRhtDg@mail.gmail.com> In-Reply-To: <51F5106D.9080806@freebsd.org> References: <51F3B731.7090608@cs.ucl.ac.uk> <20130728002022.GS81600@egr.msu.edu> <51F5106D.9080806@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
It's possible that the latest clang patches that where committed brake chromium if NULL is not defined as nullptr. Let me test this before adding clang as dep, maybe we can get away by applying the extra clang patch on later base versions. On Jul 28, 2013 3:37 PM, "Ren=C3=A9 Ladan" <rene@freebsd.org> wrote: > On 28-07-2013 02:20, Adam McDougall wrote: > > On Sat, Jul 27, 2013 at 01:04:01PM +0100, Brad Karp wrote: > > > > Given hope by Tony's experience, I tried building Chromium 28 on my > > 9.1-RELEASE amd64 box with clang33 instead of the default 9.1R clang > (3.1). > > > > Success here, too: building with clang33 fixes the "unclickable" link= s > > problem I and others had when building with 9.1R's default clang. > > > > Perhaps the port maintainer might consider requiring clang33 for thos= e > > who build with clang on 9.1R and earlier for the time being? > > > > -Brad, bkarp@cs.ucl.ac.uk > > > > After a brief test with https://scroner.com/~tony/chrome_test/ > > and nagios, I can confirm this. Thanks for the tip. > > I made trivial patch for this at > http://people.freebsd.org/~rene/patches/chromium-clang33.diff > > I think it would be good to commit this, I see similar non-clickable link= s. > > Ren=C3=A9 > _______________________________________________ > freebsd-chromium@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-chromium > To unsubscribe, send any mail to "freebsd-chromium-unsubscribe@freebsd.or= g > " >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANcjpODpL8z=f7xriGjNFbXh5PfgQx000S%2BqU9qmhy2fkRhtDg>