Date: Mon, 16 Dec 2013 21:55:13 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Devin Teske <dteske@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com> Subject: Re: svn commit: r259479 - head/usr.sbin/bsdinstall/scripts Message-ID: <C908AFBD-A497-4692-88B0-75502119890D@fisglobal.com> In-Reply-To: <52AF75C1.9040502@freebsd.org> References: <201312161947.rBGJl4Jh087762@svn.freebsd.org> <52AF6FF6.1030909@freebsd.org> <7BF56E5D-CDE7-4E57-BA47-3565CD07236C@fisglobal.com> <A039986D-9C52-42F3-8E64-42B474A484B2@fisglobal.com> <52AF75C1.9040502@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 16, 2013, at 1:50 PM, Nathan Whitehorn wrote: > On 12/16/13 15:48, Teske, Devin wrote: >> On Dec 16, 2013, at 1:40 PM, Teske, Devin wrote: >>=20 >>> On Dec 16, 2013, at 1:26 PM, Nathan Whitehorn wrote: >>>=20 >>>> On 12/16/13 13:47, Devin Teske wrote: >>>>> Author: dteske >>>>> Date: Mon Dec 16 19:47:04 2013 >>>>> New Revision: 259479 >>>>> URL: https://urldefense.proofpoint.com/v1/url?u=3Dhttp://svnweb.freeb= sd.org/changeset/base/259479&k=3D%2FbkpAUdJWZuiTILCq%2FFnQg%3D%3D%0A&r=3DMr= js6vR4%2Faj2Ns9%2FssHJjg%3D%3D%0A&m=3DfW6SVzmwwyz0yNXNK7sHp4zegrL63niU%2F%2= F21DVtgyGU%3D%0A&s=3Dcdd7f18e0151f222c2934ae69e473dac2e22e74cbde4d5af5758a0= 83fb1c3a7e >>>>>=20 >>>>> Log: >>>>> Add kern.geom.label.disk_ident.enable=3D"0" to loader.conf(5). >>>>> Discussed on: -current, -stable >>>>> MFC after: 3 days >>>>>=20 >>>>> Modified: >>>>> head/usr.sbin/bsdinstall/scripts/zfsboot >>>>>=20 >>>>> Modified: head/usr.sbin/bsdinstall/scripts/zfsboot >>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>>>> --- head/usr.sbin/bsdinstall/scripts/zfsboot Mon Dec 16 19:44:45 2013= (r259478) >>>>> +++ head/usr.sbin/bsdinstall/scripts/zfsboot Mon Dec 16 19:47:04 2013= (r259479) >>>>> @@ -1159,6 +1159,9 @@ zfs_create_boot() >>>>> $BSDINSTALL_TMPETC/rc.conf.zfs || return $FAILURE >>>>> f_eval_catch $funcname echo "$ECHO_APPEND" 'zfs_load=3D\"YES\"' \ >>>>> $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE >>>>> + f_eval_catch $funcname echo "$ECHO_APPEND" \ >>>>> + 'kern.geom.label.disk_ident.enable=3D\"0\"' \ >>>>> + $BSDINSTALL_TMPBOOT/loader.conf.zfs || return $FAILURE >>>>> # We're all done unless we should go on for boot pool >>>>> [ "$ZFSBOOT_BOOT_POOL" ] || return $SUCCESS >>>> Uh -- what is all of this? Why are we disabling kernel functions depen= ding on what the root filesystem is? Please don't MFC this. >>> https://urldefense.proofpoint.com/v1/url?u=3Dhttp://lists.freebsd.org/p= ipermail/freebsd-stable/2013-December/076365.html&k=3D%2FbkpAUdJWZuiTILCq%2= FFnQg%3D%3D%0A&r=3DLTzUWWrRnz2iN3PtHDubWRSAh9itVJ%2BMUcNBCQ4tyeo%3D%0A&m=3D= WCmXzB4036KuOzNScbJsBQLKdo%2BAo15QWLYq4A7DKis%3D%0A&s=3D4f16f0d6399e3a3c5e1= 05a7869c580884327a8721c2f44c1711b319212a23db7 >>> https://urldefense.proofpoint.com/v1/url?u=3Dhttp://lists.freebsd.org/p= ipermail/freebsd-stable/2013-December/076471.html&k=3D%2FbkpAUdJWZuiTILCq%2= FFnQg%3D%3D%0A&r=3DLTzUWWrRnz2iN3PtHDubWRSAh9itVJ%2BMUcNBCQ4tyeo%3D%0A&m=3D= WCmXzB4036KuOzNScbJsBQLKdo%2BAo15QWLYq4A7DKis%3D%0A&s=3D17882f97e3633c1e3eb= d45f332e62d2212dc53d1f0577acc4ae15d8234d09c7f >>>=20 >>> NB: Happy to rip it out... but want something in-reply to those threads= (pretty please). >> Basically... the logic is... >>=20 >> The ZFS pool is built on vdevs of a specific name. The names that are us= ed >> should remain the same. Adding this to the loader.conf ensures that the = names >> that the pool(s) was/were built upon do not change. >>=20 >> This goes beyond just a swap partition I imagine. For example... copying= the >> data to a new drive using a duplicator. I'm sure there are other cases t= oo. >=20 > Thanks for the explanation! I wonder if we should just turn off the disk = ident stuff by default globally -- it was causing problems for me as well w= ithout ZFS root. As I was making the commit to zfsboot... the very thought had occurred to m= e. I'm happy to rip this out in favor of a new global default. The end-result = is that what Johan experienced won't be repeated. I think there's an urgency to get something to solve this into 10. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C908AFBD-A497-4692-88B0-75502119890D>