Date: Tue, 28 Oct 2008 11:11:48 -0400 From: John Baldwin <jhb@freebsd.org> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184341 - head/usr.sbin Message-ID: <200810281111.48833.jhb@freebsd.org> In-Reply-To: <20081028065010.A2978@maildrop.int.zabbadoz.net> References: <200810271515.m9RFF86d042970@svn.freebsd.org> <200810271418.41291.jhb@freebsd.org> <20081028065010.A2978@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 28 October 2008 02:56:23 am Bjoern A. Zeeb wrote: > On Mon, 27 Oct 2008, John Baldwin wrote: > > > On Monday 27 October 2008 11:15:08 am Bjoern A. Zeeb wrote: > >> Author: bz > >> Date: Mon Oct 27 15:15:08 2008 > >> New Revision: 184341 > >> URL: http://svn.freebsd.org/changeset/base/184341 > >> > >> Log: > >> We do not have a libkse anymore and Mk/bsd.* does not know > >> about LIBKSE anymore, so s,MK_LIBKSE,MK_LIBPTHREAD,. > > > > Shouldn't you just remove it instead? These two options are now basically > > identical. (We probably should rename libthr to libpthread at some point.) > > tools/build/options/WITHOUT_LIBPTHREAD still talks about kse and thus > does src.conf(5). That should be updated. > I wouldn't object to removing one of the options but according to the > src.conf my bet would be LIBTHR and not LIBPTHREAD. > So updating the documentation might be a good initial step as well. Note that MK_LIBTHR == "NO" implies MK_LIBPTHREAD == "NO" (see bsd.own.mk), but not the other way around. So for now the correct knob to check in Makefiles is MK_LIBTHR (since it gets set to NO in both the WITHOUT_LIBTHR and WITHOUT_LIBPTHREAD cases, but MK_LIBPTHREAD isn't set to NO if you just do WITHOUT_LIBTHR). > I have to admit that I lost track about our threading libs in > different branches at one time; how many are left in head - 1 or 2? > Is only libthr left and we build it as libthr and add symlinks for > libpthread? Yes. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810281111.48833.jhb>