Date: Tue, 13 Jan 2009 19:02:08 +0000 (UTC) From: Andrew Thompson <thompsa@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r187167 - head/sys/dev/usb2/controller Message-ID: <200901131902.n0DJ284X012182@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: thompsa Date: Tue Jan 13 19:02:07 2009 New Revision: 187167 URL: http://svn.freebsd.org/changeset/base/187167 Log: MFp4: //depot/projects/usb@155759 Optimise: Remove extra flush calls. Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb2/controller/ohci2.c Modified: head/sys/dev/usb2/controller/ohci2.c ============================================================================== --- head/sys/dev/usb2/controller/ohci2.c Tue Jan 13 19:01:56 2009 (r187166) +++ head/sys/dev/usb2/controller/ohci2.c Tue Jan 13 19:02:07 2009 (r187167) @@ -1558,13 +1558,12 @@ ohci_setup_standard_chain(struct usb2_xf } ed->ed_flags = htole32(ed_flags); - usb2_pc_cpu_flush(ed->page_cache); - td = xfer->td_transfer_first; ed->ed_headp = td->td_self; if (xfer->udev->pwr_save.suspended == 0) { + /* the append function will flush the endpoint descriptor */ OHCI_APPEND_QH(ed, *ed_last); if (methods == &ohci_device_bulk_methods) { @@ -2009,13 +2008,12 @@ ohci_device_isoc_enter(struct usb2_xfer } ed->ed_flags = htole32(ed_flags); - usb2_pc_cpu_flush(ed->page_cache); - td = xfer->td_transfer_first; ed->ed_headp = td->itd_self; /* isochronous transfers are not affected by suspend / resume */ + /* the append function will flush the endpoint descriptor */ OHCI_APPEND_QH(ed, sc->sc_isoc_p_last); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901131902.n0DJ284X012182>