Date: Thu, 21 Sep 2000 00:14:38 +0200 From: Maxime Henrion <mux@qualys.com> To: David Malone <dwmalone@maths.tcd.ie>, stable@freebsd.org Subject: Re: patch for inetd Message-ID: <39C936CE.FA1AAF31@qualys.com> References: <39C8D00D.FBE1407F@qualys.com> <20000920165505.A56705@walton.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
David Malone wrote: > > *** /usr/src/usr.sbin/inetd/builtins.c Wed Sep 20 16:49:26 2000 > > --- builtins.c Wed Jul 19 22:27:19 2000 > > *************** > > *** 480,487 **** > > ssize = read(s, &buf[size], (size_t)onreadlen); > > if (ssize == -1) > > iderror(0, 0, s, errno); > > - else if (ssize == 0) > > - return; > > bufsiz -= ssize; > > size += ssize; > > } > > --- 480,485 ---- > > You don't wan't to return from the ident builtin, I'd actually > suggest "break;" to see if you've recieved enough of a request to > be able to answer. You may still be able to send data to the other > end, as they may just have shutdown half of the connection. > I didn't know that at all, so a "break;" is effectively more appropriate. > > Alfred's patch with the iderror for the EOF case is reasonable, > but I'd be as lienient as possible and attempt to answer the request. > Yeah, I got Alfred's patch after having sent mine. > > I'll test the patch with a break; when I get home and see if it > works OK. If alfred thinks it's OK I'll commit it. Great ! > David. Maxime PS: I'm sure you've noticed, but the I did the diff in the wrong sense, sorry. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39C936CE.FA1AAF31>