Date: Wed, 14 Dec 2011 20:49:40 +0000 From: Michael Scheidell <michael.scheidell@secnap.com> To: Ryan Steinmetz <zi@FreeBSD.org> Cc: Michael Scheidell <scheidell@FreeBSD.org>, Wesley Shields <wxs@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org>, "gabor@FreeBSD.org" <gabor@FreeBSD.org>, "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org> Subject: Re: cvs commit: ports/net-mgmt/net-snmp Makefile Message-ID: <c2c22665-79b0-45a0-a28a-cb942a20d265@blur> In-Reply-To: <1ac141b1-6c9f-4023-90f7-270831c9e989@blur> References: <1ac141b1-6c9f-4023-90f7-270831c9e989@blur>
next in thread | previous in thread | raw e-mail | index | archive | help
Pr logs show pings were made. Timeout was well past conventional 14 days with no response . Sorry but all indications were that noone was working in the port. As for Python bindings if the default is off it would not have made those attempts anyway. Back it out and reopen the pr or leave it clised -- Michael Scheidell, CTO SECNAP Network Security -----Original message----- From: Ryan Steinmetz <zi@FreeBSD.org> To: Michael Scheidell <michael.scheidell@secnap.com> Cc: Wesley Shields <wxs@FreeBSD.org>, Michael Scheidell <scheidell@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org>, "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>, "gabor@FreeBSD.org" <gabor@FreeBSD.org> Sent: Wed, Dec 14, 2011 20:44:29 GMT+00:00 Subject: Re: cvs commit: ports/net-mgmt/net-snmp Makefile On (12/14/11 17:09), Michael Scheidell wrote: > Hmm. I wonder why I missed something as simple as that. > > Tinderbox didn't complain. > -- > Michael Scheidell, CTO > SECNAP Network Security > > > -----Original message----- > From: Wesley Shields <wxs@FreeBSD.org> > To: Michael Scheidell <scheidell@FreeBSD.org> > Cc: "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org>, "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org>, "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org> > Sent: Wed, Dec 14, 2011 16:48:54 GMT+00:00 > Subject: Re: cvs commit: ports/net-mgmt/net-snmp Makefile > > On Wed, Dec 14, 2011 at 01:08:08PM +0000, Michael Scheidell wrote: > > scheidell 2011-12-14 13:08:08 UTC > > > > FreeBSD ports repository > > > > Modified files: > > net-mgmt/net-snmp Makefile > > Log: > > - re-integration which enables the option of building the python bindings [1] > > - with the addition of a options knob (off by default) > > - No portsbump so that its a 'noop' for systems that don't need python bindings > > > > PR: ports/162140 > > Submitted by: Geoffrey Huntley <ghuntley@ghuntley.com> [1] > > Approved by: zi (maintainer timeout, 30 days), gabor (mentor) > > > > Revision Changes Path > > 1.199 +8 -1 ports/net-mgmt/net-snmp/Makefile > > http://cvsweb.FreeBSD.org/ports/net-mgmt/net-snmp/Makefile.diff?r1=1.198&r2=1.199 > > | --- ports/net-mgmt/net-snmp/Makefile 2011/12/07 22:58:31 1.198 > > | +++ ports/net-mgmt/net-snmp/Makefile 2011/12/14 13:08:08 1.199 > > | @@ -2,7 +2,7 @@ > > | # Date created: 26 June 1996 > > | # Whom: gpalmer > > | # > > | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/net-mgmt/net-snmp/Makefile,v 1.198 2011/12/07 22:58:31 zi Exp $ > > | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/net-mgmt/net-snmp/Makefile,v 1.199 2011/12/14 13:08:08 scheidell Exp $ > > | # > > | > > | PORTNAME= snmp > > | @@ -23,7 +23,8 @@ OPTIONS= IPV6 "Build with IPv6 support" > > | DUMMY "Enable dummy values as placeholders" on \ > > | TKMIB "Install graphical MIB browser" off \ > > | DMALLOC "Enable dmalloc debug memory allocator" off \ > > | - UNPRIVILEGED "Allow unprivileged users to execute net-snmp" off > > | + UNPRIVILEGED "Allow unprivileged users to execute net-snmp" off \ > > | + PYTHON "Install python bindings off > > Missing quote here. > > -- WXS Please revert this change and re-open the PR, my reasoning is as follows: - It doesn't solve the problem in the PR. The submitters patch had problems which caused it not to work properly. - USE_PYDISTUTILS= is inappropriate and doesn't work in this situation. Please review bsd.python.mk for what this actually does and when to use it. - You did not review the tinderbox build log or you would have noticed that the log indicated: "checking for python... no" - You clearly did not test the python bindings prior to committing. - If everything did work, the port would have installed additional files into the python directories which would also have required plist changes. Based on these issues and the issue that wxs@ pointed out, I highly recommend you review your tinderbox settings/practices. It would also be appreciated to ping the maintainer letting them know that you plan to make commits to their port. If you don't hear anything back within a couple days (and it's in a maintainer timeout state), then proceed. I had reviewed this PR and had been investigating a solution. If you had reached out, I would have been able to share this with you. -r -- Ryan Steinmetz PGP: EF36 D45A 5CA9 28B1 A550 18CD A43C D111 7AD7 FAF2
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c2c22665-79b0-45a0-a28a-cb942a20d265>