Date: Wed, 5 Jan 2005 23:30:38 GMT From: Julian Elischer <julian@elischer.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/75831: [bktr] [patch] incorrect autodetection of Pinnacle cards Message-ID: <200501052330.j05NUc4q004163@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/75831; it has been noted by GNATS.
From: Julian Elischer <julian@elischer.org>
To: =?ISO-8859-1?Q?=22Arne_=5C=22W=F6rner=5C=22=22?= <arne_woerner@yahoo.com>
Cc: freebsd-gnats-submit@FreeBSD.org, branko@euro.net,
Michael Nottebrock <michaelnottebrock@gmx.net>
Subject: Re: kern/75831: [bktr] [patch] incorrect autodetection of Pinnacle
cards
Date: Wed, 05 Jan 2005 15:25:58 -0800
Arne Wörner wrote:
>I tested Brankos newest patch together with the suggested patch in
>kern/73324 (it detects the card automatically from the vendor_id;
>see appendix B) and it works fine for me with a PCTV Rave card
>with MT2032 tuner (see appendix A).
>
>I think, that should solve Michael's auto detection problem,
>too... Auto detection is cooler than manually setting the tuner,
>I think, although manually setting the tuner is quite convinient,
>too.
>
>Thanks...
>
>-Arne
>
>appendix A: dmesg
>Jan 5 20:24:18 neo kernel: bktr1: <BrookTree 878> mem
>0xdfcfc000-0xdfcfcfff irq 10 at device 9.0 on pci0
>Jan 5 20:24:18 neo kernel: bktr1: [GIANT-LOCKED]
>Jan 5 20:24:18 neo kernel: bktr1: MT2032: Companycode=4d54
>Part=04 Revision=04
>Jan 5 20:24:18 neo kernel: bktr1: Pinnacle PCTV Rave, MT2032
>tuner.
>
>appendix B: modified kern/73324 patch
> if (subsystem_vendor_id == PCI_VENDOR_PINNACLE_ALT
>||
> subsystem_vendor_id ==
>PCI_VENDOR_PINNACLE_NEW) {
> bktr->card = cards[ (card = CARD_MIRO) ];
> bktr->card.eepromAddr = eeprom_i2c_address;
> bktr->card.eepromSize = (u_char)(256 /
>EEPROMBLOCKSIZE);
> goto checkTuner;
> }
>
>
let me know when you have a patch that I should commit..
In the meantime how about EVERYONE with a brooktree tuner check that this
patch doesn't break them.
>
>
>
>__________________________________
>Do you Yahoo!?
>Yahoo! Mail - 250MB free storage. Do more. Manage less.
>http://info.mail.yahoo.com/mail_250
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200501052330.j05NUc4q004163>