Date: Mon, 28 Feb 2005 01:27:24 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/cardbus cardbus.c Message-ID: <200502280127.j1S1ROkh066282@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2005-02-28 01:27:24 UTC
FreeBSD src repository
Modified files:
sys/dev/cardbus cardbus.c
Log:
There were two calls to cardbus_do_cis when cardbus_do_cis changed,
yet I only changed one of them. So when we loaded drivers, we'd fail
to allocate resources correct.
This pointed out that we were doing the wrong thing when we failed to
attach a child. We released all the resources and almost deleted the
child. Instead, we should keep the resources allocated so when/if a
driver is loaded, we can go w/o having to allocate them. We use
pci_cfg_save/restore to restore the BARs with these resources.
This seems to fix the problems that we were seeing that I thought
might have magically gone away in the last revision of cardbus.c (but
really didn't).
Noticed by: avatar (nicely done!)
Revision Changes Path
1.49 +5 -7 src/sys/dev/cardbus/cardbus.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502280127.j1S1ROkh066282>