Date: Mon, 23 May 2016 23:06:16 +0300 From: "Andriy Voskoboinyk" <avos@freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Allan Jude" <allanjude@freebsd.org> Subject: Re: svn commit: r298946 - head/usr.sbin/bsdinstall/scripts Message-ID: <op.yhxl4qde4dikkl@localhost> In-Reply-To: <e01538e8-0b18-754a-5949-47a85533ecab@freebsd.org> References: <201605022140.u42LeYFK051507@repo.freebsd.org> <186c070f-eb81-370d-b215-1d9f370918b8@freebsd.org> <e01538e8-0b18-754a-5949-47a85533ecab@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mon, 23 May 2016 08:00:27 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Allan Jude = <allanjude@freebsd.org>: > On 2016-05-23 00:49, Allan Jude wrote: >> On 2016-05-02 17:40, Andriy Voskoboinyk wrote: >>> Author: avos >>> Date: Mon May 2 21:40:34 2016 >>> New Revision: 298946 >>> URL: https://svnweb.freebsd.org/changeset/base/298946 >>> >>> Log: >>> bsdinstall: fix static address assignment for protected wireless = >>> networks. >>> >>> Filter out IFCONFIG_PREFIX variable (which may contain WPA keyword= ) >>> from ifconfig parameters. >>> >>> PR: 169199 >>> >>> Modified: >>> head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 >>> >>> Modified: head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >>> --- head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 Mon May 2 = >>> 21:23:05 2016 (r298945) >>> +++ head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 Mon May 2 = >>> 21:40:34 2016 (r298946) >>> @@ -84,7 +84,7 @@ retval=3D$? >>> >>> if [ "$BSDINSTALL_CONFIGCURRENT" ]; then >>> . $BSDINSTALL_TMPETC/._rc.conf.net >>> - ifconfig $INTERFACE `eval echo \\\$ifconfig_$INTERFACE` >>> + ifconfig $INTERFACE `eval echo \\\$ifconfig_$INTERFACE | sed = >>> "s|$2||"` >>> if [ "$defaultrouter" ]; then >>> route delete -inet default >>> route add -inet default $defaultrouter >>> >> >> This breaks static assignment of IP addresses to wired interfaces: >> >> sed: first RE may not be empty >> >> > > I wrote this patch for the issue. Unless you see a better way to do it= ? > > No, I have no better ideas.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?op.yhxl4qde4dikkl>