Date: Mon, 16 Jan 2017 19:57:50 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312331 - head/contrib/bsnmp/snmpd Message-ID: <2C5D1730-6F2F-4D57-B977-420B0CFA81B1@gmail.com> In-Reply-To: <201701170352.v0H3qvNJ025187@repo.freebsd.org> References: <201701170352.v0H3qvNJ025187@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Jan 16, 2017, at 19:52, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > > Author: glebius > Date: Tue Jan 17 03:52:57 2017 > New Revision: 312331 > URL: https://svnweb.freebsd.org/changeset/base/312331 > > Log: > Fix regression from r310655, which broke operation of bsnmpd if it is bound > to a non-wildcard address. As documented in ip(4), doing sendmsg(2) with > IP_SENDSRCADDR on a socket that is bound to non-wildcard address is > completely different to using this control message on a wildcard one. > > A fix is to add a bool to mark whether we did setsockopt(IP_RECVDSTADDR) > on the socket, and use IP_SENDSRCADDR control message only if we did. > > While here, garbage collect absolutely useless udp_recv() function that > establishes some structures on stack to never use them later. I wasn’t aware of that — thank you for fixing my mistake (and I’ll add you to the next set of CRs here). udp_recv(..) was meant to provide a layer for doing the necessary bits for IPv6.. I guess I’ll have to adjust (and hope that the team doing it internally “gets it right”). Cheers, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYfZY+AAoJEPWDqSZpMIYVjSoQALZ4adbErShz4VYpa0wjF61Q krmDlBndAAKp3n6bfTCqfh+Yw+nhXhjjLffe40igpgr1y+EMfJktstkreNiGreXV ZO3G55b0iP7MpsQHfgTFDRKzuRP0yfkqin8w/5N4KMVxpZ7oPjC6DGKDfbFxTmc3 I1CftNo1SW9szQFgYw6ScPY+eZ8ECnrwUOnPUdC/IBH50N01amQeS44n1ZPGa2Ds ZpHC2R0XDGEtTQblmmOuFDVG/fKfCAyk5rrZVcv6d7J7ADivYgnYU/NnT6Low7l8 c2+J3TaBC7OuLOwPdJFGRYR6urWWLMDiMTEXFVoIRbotljqA8tPHsqbEB6mUt1AT GFhwQ10Nzf5y6635LX1P18wuKyFmiN/fdvWakKosvbM4k+DXxJJvjP4FhrOpgO/h +7UQ/MJiYcgK6MMAjM/KCyKlU4bZJz8O+3r0sPfZiC2VpQQvFH5FYUeSxTzHU7gf AZN7Tz6DjjNjHKDXgkWdz9bZZ9LsG61E7IuiEn6dI+oLoDBJi8SJz+rXuiNfshHm JUVzgpYmfZZh5HX5McW13PlPwlni9jKBebmPqpGYQOMaEskBFxaccT95vsam/QDi mQ850BvORbAK1jTSYnaJXtP9CdFODBgWS9OiNyYxPc4ZTDbLajfvjXISe4VjIZ9d ZT1c9EjvAl+2alk7k2a+ =cAcQ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2C5D1730-6F2F-4D57-B977-420B0CFA81B1>