Date: Sat, 16 Mar 1996 10:03:46 +0100 (MET) From: sos@FreeBSD.org To: dyson@FreeBSD.org Cc: current@FreeBSD.org, mmead@glock.com Subject: Re: Try this vm_mmap.c -- please Message-ID: <199603160903.KAA00185@DeepCore.dk> In-Reply-To: <199603160046.AAA00402@dyson.iquest.net> from "John S. Dyson" at Mar 16, 96 00:46:42 am
next in thread | previous in thread | raw e-mail | index | archive | help
In reply to John S. Dyson who wrote:
>
> This vm_mmap.c contains what I believe some fixes to the mmap code. Note
> that there were some severe bogons in the code, and one that I cannot
> easily get rid of. Firstly we allow mmaps that don't have either MAP_PRIVATE or
> MAP_SHARED set. This is wrong because logically one is necessary. The
> solution is that I default to MAP_PRIVATE for vnodes and MAP_SHARED for
> devices (video memory.) Also, the old code did not allow for shared
> anonymous mappings, this is very bogus. Eventually, we should enforce
> a MAP_PRIVATE or MAP_SHARED bit being set, but there is code out there
> like XFree that doesn't specify either bit, and since it was originally
> not "wrong", it is a PROBLEM :-(. PLEASE PLEASE give me some feedback on
> this, as my entire life for this weekend is dedicated to fixing this
> problem (not really, but you know what I mean.) :-).
Sorry, but it still breaks my accelx server :(
I guess you are in for a looonngg weekend :)
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team
Even more code to hack -- will it ever end
..
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199603160903.KAA00185>