Date: Fri, 11 May 2012 06:02:44 -0700 From: Colin Percival <cperciva@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Gabor Kovesdan <gabor@freebsd.org> Subject: Re: svn commit: r235267 - in head/usr.bin/sort: . nls Message-ID: <4FAD0DF4.9000609@freebsd.org> In-Reply-To: <20120511124820.GN2358@deviant.kiev.zoral.com.ua> References: <201205111237.q4BCbGX2083596@svn.freebsd.org> <20120511124820.GN2358@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/11/12 05:48, Konstantin Belousov wrote: > On Fri, May 11, 2012 at 12:37:16PM +0000, Gabor Kovesdan wrote: >> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >> unsigned char **cmonths = NULL; > > Such initializations are useless. You only increase the size of the binary > on the disk as the consequence. I just tested this hypothesis, and found no change in binary size using either clang or gcc46. Presumably they're smart enough to ignore explicit (and unnecessary) initializations of statics to zero. -- Colin Percival Security Officer, FreeBSD | freebsd.org | The power to serve Founder / author, Tarsnap | tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FAD0DF4.9000609>