Date: Fri, 19 Nov 2004 10:40:33 GMT From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/50613: [PATCH] pppd(8) incorrect CBCP response for admin-specified number Message-ID: <200411191040.iAJAeXQm053283@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/50613; it has been noted by GNATS.
From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc:
Subject: Re: bin/50613: [PATCH] pppd(8) incorrect CBCP response for
admin-specified number
Date: Fri, 19 Nov 2004 12:30:24 +0200 (EET)
Hello!
Due to changes in cbcp.c my previuos patch won't apply - I've regenerated
it to match cbcp.c version "1.4.2.1 2004/11/18 15:21:41 delphij"
--- cbcp.c.orig Fri Nov 19 12:17:56 2004
+++ cbcp.c Fri Nov 19 12:27:34 2004
@@ -345,10 +345,9 @@
if (cb_type & ( 1 << CB_CONF_ADMIN ) ) {
syslog(LOG_DEBUG, "cbcp_resp CONF_ADMIN");
PUTCHAR(CB_CONF_ADMIN, bufp);
- len = 3 + 1;
+ len = 3;
PUTCHAR(len , bufp);
PUTCHAR(5, bufp); /* delay */
- PUTCHAR(0, bufp);
cbcp_send(us, CBCP_RESP, buf, len);
return;
}
@@ -356,9 +355,8 @@
if (cb_type & ( 1 << CB_CONF_NO ) ) {
syslog(LOG_DEBUG, "cbcp_resp CONF_NO");
PUTCHAR(CB_CONF_NO, bufp);
- len = 3;
+ len = 2;
PUTCHAR(len , bufp);
- PUTCHAR(0, bufp);
cbcp_send(us, CBCP_RESP, buf, len);
(*ipcp_protent.open)(us->us_unit);
return;
Sincerely, Dmitry
--
Atlantis ISP, System Administrator
e-mail: dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200411191040.iAJAeXQm053283>