Date: Thu, 30 Apr 2009 10:13:40 -0700 From: Kip Macy <kmacy@freebsd.org> To: Ben Kelly <ben@wanderview.com> Cc: current@freebsd.org Subject: Re: [patch] zfs livelock and thread priorities Message-ID: <3c1674c90904301013k1ca3b0d9x4f3389591db99a0b@mail.gmail.com> In-Reply-To: <E24CFA2F-5350-4B64-8808-7648205B5BBB@wanderview.com> References: <AC3C4C3F-40C6-4AF9-BAF3-2C4D1E444839@wanderview.com> <F86D3461-3ABD-4A56-B9A6-36857364DF4B@wanderview.com> <4D8E4457-89AA-4F19-9960-E090D3B8E319@wanderview.com> <20090429064303.GA2189@a91-153-125-115.elisa-laajakaista.fi> <A83EA714-1EB5-41C1-91E2-FD031FD0DE0E@wanderview.com> <DA5E47A7-8D3C-4D79-A36E-4460ADC9E3F3@wanderview.com> <49F8E71B.2020102@freebsd.org> <38E0E938-68DA-4D2E-8191-3CEC836A82E9@wanderview.com> <3c1674c90904300019w63f31ac0n141c3d5116eadb97@mail.gmail.com> <E24CFA2F-5350-4B64-8808-7648205B5BBB@wanderview.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 30, 2009 at 8:55 AM, Ben Kelly <ben@wanderview.com> wrote: > On Apr 30, 2009, at 3:19 AM, Kip Macy wrote: >> >> I have a system at work that I could lock up within minutes with >> fsstress. With this patch the system is now stable with large numbers >> of fsstress processes running. >> >> Provided I get the heads up from pjd, I will commit it. > > I found on my system that I could not zfs export my pool after running my > load test with this patch. =A0To try to fix this I've updated the patch t= o > delegate to vrele(9) instead of directly decrementing the vnode count. = =A0I > also modified the deferred operation to restart a full vrele(9) instead o= f > calling VOP_INACTIVE since it occurred to me someone else might have grab= bed > the vnode while our task was on the queue. =A0I have only had time to run= a > short test, but it seems to avoid the problem so far. > > Can you retest with these changes? >\ I'll try deferring the entire vrele. -Kip
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3c1674c90904301013k1ca3b0d9x4f3389591db99a0b>