Date: Sun, 03 Feb 2013 12:23:25 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r246251 - head/sys/dev/acpica Message-ID: <510E3A9D.7040005@FreeBSD.org> In-Reply-To: <20130202151137.GA28366@FreeBSD.org> References: <201302021244.r12CiKgj046079@svn.freebsd.org> <20130202125122.GA4975@FreeBSD.org> <20130202151137.GA28366@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 02/02/2013 17:11 Alexey Dokuchaev said the following: > On Sat, Feb 02, 2013 at 12:51:22PM +0000, Alexey Dokuchaev wrote: >> On Sat, Feb 02, 2013 at 12:44:20PM +0000, Andriy Gapon wrote: >>> New Revision: 246251 >>> URL: http://svnweb.freebsd.org/changeset/base/246251 >>> >>> Log: >>> acpi: clear power button status bit after waking up... >>> so that it is not confused for a new power off request. >> >> Hmm, I was annoyed by this bug for a while. Will try to test it with >> 8-stable tonight, thanks! > > Andriy, it appears to me that ACPI code is substantially different between > 8-stable and head, so the patch cannot be applied as is. I'm not sure where > exactly inside acpi_EnterSleepState() does it belong. Could you provide me > with some guidance (or even patch for 8-stable)? Thanks. Yes, this is unfortunately so. It seems that some fellow developers who hack on ACPI-related code prefer to not MFC at all. I am not ready yet to provide a stable/8 patch and may give up on MFC to stable/8 altogether. P.S. logically the new block of code seems to belong to acpi_sleep_machdep() before intr_restore() call. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?510E3A9D.7040005>