Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 21 Jun 2009 10:20:22 +0200
From:      Roman Divacky <rdivacky@freebsd.org>
To:        current@freebsd.org
Subject:   [PATCH]: if (cond); foo() in firewire
Message-ID:  <20090621082022.GA88526@freebsd.org>
next in thread | raw e-mail | index | archive | help 

--WIyZ46R2i8wDzkSu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

hi

is this patch correct? may I commit it?

Index: ../../../dev/firewire/fwdev.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- ../../../dev/firewire/fwdev.c       (revision 194573)
+++ ../../../dev/firewire/fwdev.c       (working copy)
@@ -443,7 +443,7 @@
        xfer->send.pay_len =3D uio->uio_resid;
        if (uio->uio_resid > 0) {
                if ((err =3D uiomove((caddr_t)&xfer->send.payload[0],
-                   uio->uio_resid, uio)));
+                   uio->uio_resid, uio)))
                        goto out;
        }
=20

another bug found by the "useless warnings in clang" ;)

roman

--WIyZ46R2i8wDzkSu
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (FreeBSD)

iEYEARECAAYFAko97UYACgkQLVEj6D3CBEwJ+ACfc+s+GXxs+vHFZ6C0uFpFlh3X
9dkAnA4+I2l2Mpm40D8K0Xhh3x1uNuzY
=Fc1q
-----END PGP SIGNATURE-----

--WIyZ46R2i8wDzkSu--

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090621082022.GA88526>