Date: Thu, 01 Oct 2015 10:01:20 -0700 From: John Baldwin <jhb@freebsd.org> To: src-committers@freebsd.org Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288452 - head/sys/dev/drm2/i915 Message-ID: <90323889.l5UMs3tJRz@ralph.baldwin.cx> In-Reply-To: <201510011659.t91Gx8SX094039@repo.freebsd.org> References: <201510011659.t91Gx8SX094039@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, October 01, 2015 04:59:08 PM John Baldwin wrote: > Author: jhb > Date: Thu Oct 1 16:59:07 2015 > New Revision: 288452 > URL: https://svnweb.freebsd.org/changeset/base/288452 > > Log: > Most error cases in i915_gem_do_execbuffer() jump to one of two labels to > release resources (such as unholding pages) when errors occur. Some > recently added error checks return immediately instead of jumping to a > label resulting in leaks. Fix these to jump to a label to do cleanup > instead. I was getting panics due to the hold count on pages being negative in this function. The hold counts were quiet high and so I believe that the hold count overflowed to zero due to these leaks and triggered the panic. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?90323889.l5UMs3tJRz>