Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Oct 2014 11:38:27 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 191263] [patch] dd(1): Incorrect casting of arguments
Message-ID:  <bug-191263-8-hv6u2Yuhog@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-191263-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-191263-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191263

--- Comment #9 from commit-hook@freebsd.org ---
A commit references this bug:

Author: pi
Date: Mon Oct 27 11:38:19 UTC 2014
New revision: 273734
URL: https://svnweb.freebsd.org/changeset/base/273734

Log:
  bin/dd: Fix incorrect casting of arguments

  dd(1) casts many of its numeric arguments from uintmax_t to intmax_t
  and back again to detect whether or not the original arguments were
  negative. This caused wrong behaviour in some boundary cases:

  $ dd if=/dev/zero of=/dev/null count=18446744073709551615
  dd: count cannot be negative

  After the fix:

  $ dd if=/dev/zero of=/dev/null count=18446744073709551615
  dd: count: Result too large

  PR:        191263
  Submitted by:    will@worrbase.com
  Approved by:    cognet@

Changes:
  head/bin/dd/args.c
  head/bin/dd/conv.c
  head/bin/dd/dd.c
  head/bin/dd/dd.h
  head/bin/dd/position.c

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191263-8-hv6u2Yuhog>