Date: Tue, 11 Dec 2001 14:30:41 -0800 From: Peter Wemm <peter@wemm.org> To: Josef Karthauser <joe@tao.org.uk> Cc: Alexey Zelkin <phantom@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/binutils/gdb/i386 kvm-fbsd.c Message-ID: <20011211223041.4EA013808@overcee.netplex.com.au> In-Reply-To: <20011211171406.C27214@tao.org.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Josef Karthauser wrote: > > --raC6veAxrt5nqIoY > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Tue, Dec 11, 2001 at 06:58:47PM +0200, Alexey Zelkin wrote: > >=20 > > > Is it worth having the commit fail if there's a null log message? > >=20 > > It could be useful as for me. But make sure that it should work correctly > > in both pserver and local modes. In pserver mode it's not a problem to > > check for null commit log and fail since all files are comiting at once, > > but in local mode following scenario may exists: > >=20 > > . hack files in few directories > > . do cvs commit > > . write correct log for first directory files > > . emptify log for second directory > >=20 > > in this case scripts will fail to continue and don't send email with > > "(null)" content, but patches for first directory are already applied. > > As result we have complete commit (at least part) and no notification > > sent. > > No, I don't think that this is the case. By the time the CVSROOT > scripts get the commit message cvs has already replaced the (null) log > with the original message. FWIW: there was a "reference to uninitialized variable" at (I think) line 51 of log_accum.pl (I think) when this happened. I'd almost be inclined to tweak cvs itself to reject empty log messages. > =20 > > PS: What about fix with current "$FreeBSD$ line mungled" CVSROOT problem ? > > Bunch of patches from my tree awaiting to be commited! :) > > Tonight. I've got a patch, but haven't tested it yet. I only got back > from Austria yesterday. > > Joe > > --raC6veAxrt5nqIoY > Content-Type: application/pgp-signature > Content-Disposition: inline > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.0.6 (FreeBSD) > Comment: For info see http://www.gnupg.org > > iEUEARECAAYFAjwWPt0ACgkQXVIcjOaxUBYtNgCYpHPV/ukqEjMA1W4sKP7MTE2D > kwCfUgsSsPiGFIu+AqnHBE55RXddXcQ= > =IZyj > -----END PGP SIGNATURE----- > > --raC6veAxrt5nqIoY-- > > Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011211223041.4EA013808>