Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Apr 2020 01:58:59 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 245629] textproc/py-sphinx: Update to 3.0.1
Message-ID:  <bug-245629-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245629

            Bug ID: 245629
           Summary: textproc/py-sphinx: Update to 3.0.1
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: python@FreeBSD.org
          Reporter: dbaio@freebsd.org
                CC: python@FreeBSD.org
             Flags: maintainer-feedback?(python@FreeBSD.org)
          Assignee: python@FreeBSD.org
 Attachment #213400 maintainer-approval?(python@FreeBSD.org)
             Flags:
                CC: python@FreeBSD.org

Created attachment 213400
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D213400&action=
=3Dedit
sphinx-v3.0.1-v1.8.5-PR.patch

Before applying the patch:
  $ svn cp textproc/py-sphinx textproc/py-sphinx18
  $ svn patch sphinx-v3.0.1-v1.8.5-PR.patch

Plan:

- Repocopy textproc/py-sphinx to textproc/py-sphinx18, then upgrade it to 1=
.8.5
(latest version from 1.8.X).

  This version supports Python 2 and 3.
  Add test target.

- textproc/py-sphinx: Update to 3.0.1

  Python 3 only, 3.5+
  Add test target.
  Add new ports (PR's will be linked here)

- Mk/Uses/python.mk: Add PY_SPHINX

  To use with flavors and not break ports with USES=3Dpython (all versions).
    Python >=3D3.5  --> textproc/py-sphinx (v3.0.1)
    Python < 3.5  --> textproc/py-sphinx18 (v1.8.5)

  All ports that uses sphinx were changed to use the new variable ${PY_SPHI=
NX}
in the dependency line, exceptions:

    * Ports that fails to build with sphinx 3.0.1 because of code.=20
      They are pointing to textproc/py-sphinx18 directly.
      There aren't many ports.

    * Ports that don't know Python flavors.


- Add several patches to fix sphinx consumers

  The most common issues are related with pkg-plist, the output files from
sphinx changes between versions, I tried to keep ports generating it
dynamically.=20
  This will save our time in the future sphinx updates.


Tests:

  mini exp-run on all consumers, 2412 ports (all flavors).

  textproc/py-sphinx18:
    make test: 4 failed, 1324 passed, 23 skipped, 487 warnings in 84.17 sec=
onds
        test_correct_year[expect_date1] - tests/test_correct_year.py:37:
AssertionErro
        test_ext_imgconverter - tests/test_ext_imgconverter.py:23:
AssertionError
        test_text_definition_terms - tests/test_intl.py:268: AssertionError
        test_gettext_definition_terms - tests/test_intl.py:530: AssertionEr=
ror

  textproc/py-sphinx:
    make test:  1 failed, 1432 passed, 29 skipped, 37 warnings in 97.99 sec=
onds
        WARNING: convert command 'convert' cannot be run, check the
image_converter setting
        needs to investigate, docutils, imagemagick related

  IMHO this is very reasonable result, if you compare them with the current
version (which is not even working in the tree):
    textproc/py-sphinx (current version in the ports tree v1.6.5):
        make test: 2 failed, 188 passed, 9 skipped, 36 warnings, 956 error =
in
11.96 seconds

  But tests can certainly be improved in the following updates.



Looking forward for your feedback.
And if this patch is fine, I Would like to ask for an exp-run.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-245629-21822>