Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jun 2005 21:51:13 +0400
From:      Andrey Chernov <ache@nagual.pp.ru>
To:        Paul Saab <ps@FreeBSD.ORG>, mohan_srinivasan@yahoo.com
Cc:        cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/netinet tcp_sack.c
Message-ID:  <20050609175113.GA64124@nagual.pp.ru>
In-Reply-To: <200506091401.j59E14cT033280@repoman.freebsd.org>
References:  <200506091401.j59E14cT033280@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 09, 2005 at 02:01:04PM +0000, Paul Saab wrote:
>   Modified files:
>     sys/netinet          tcp_sack.c 
>   Log:
>   Fix for a crash in tcp_sack_option() caused by hitting the limit on
>   the number of sack holes.

Some cut&paste mistake obviously happens. I see now _two_ identical
tcp_sackhole_insert() in tcp_sack.c v1.23:

                temp = tcp_sackhole_insert(tp, tp->snd_fack,sblkp->start,NULL);
                if (temp == NULL)
                        return 0;
                tcp_sackhole_insert(tp, tp->snd_fack, sblkp->start, NULL);

-- 
http://ache.pp.ru/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050609175113.GA64124>