Date: Wed, 10 Apr 2019 11:02:08 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Edward Tomasz Napierala <trasz@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346081 - head/cddl/usr.sbin/zfsd Message-ID: <4BDE4771-EA33-4746-851E-674EF31D0174@gmail.com> In-Reply-To: <20190410155509.GU1923@kib.kiev.ua> References: <201904101342.x3ADgbXM033389@repo.freebsd.org> <20190410155509.GU1923@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 10, 2019, at 08:55, Konstantin Belousov <kostikbel@gmail.com> wrote: > >> On Wed, Apr 10, 2019 at 01:42:37PM +0000, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Wed Apr 10 13:42:37 2019 >> New Revision: 346081 >> URL: https://svnweb.freebsd.org/changeset/base/346081 >> >> Log: >> Make zfsd(8) build obey CFLAGS. >> >> Reviewed by: imp >> Obtained from: CheriBSD >> MFC after: 2 weeks >> Sponsored by: DARPA, AFRL >> Differential Revision: https://reviews.freebsd.org/D19865 >> >> Modified: >> head/cddl/usr.sbin/zfsd/Makefile.common >> >> Modified: head/cddl/usr.sbin/zfsd/Makefile.common >> ============================================================================== >> --- head/cddl/usr.sbin/zfsd/Makefile.common Wed Apr 10 13:41:34 2019 (r346080) >> +++ head/cddl/usr.sbin/zfsd/Makefile.common Wed Apr 10 13:42:37 2019 (r346081) >> @@ -30,7 +30,7 @@ INCFLAGS+= -I${SRCTOP}/sys/cddl/contrib/opensolaris/ut >> INCFLAGS+= -I${SRCTOP}/sys/cddl/contrib/opensolaris/uts/common/fs/zfs >> INCFLAGS+= -I${SRCTOP}/cddl/usr.sbin >> >> -CFLAGS= -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} >> +CFLAGS+= -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} > Why the flags unconditionally set -g ? It shouldn’t be explicitly set. That’s what DEBUG_FLAGS is for. -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BDE4771-EA33-4746-851E-674EF31D0174>