Date: Wed, 11 Jun 2003 22:53:41 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c pccbbvar.h Message-ID: <20030611225111.E42109@root.org> In-Reply-To: <20030612033735.0B7D337B495@hub.freebsd.org> References: <20030612033735.0B7D337B495@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 11 Jun 2003, Warner Losh wrote:
> Modified files:
> sys/dev/pccbb pccbb.c pccbbvar.h
> Log:
> Make cbb interrupts MPSAFE:
We need to have you at bsdcon 24/7. ;-)
> --- src/sys/dev/pccbb/pccbb.c:1.75 Sat Jun 7 13:47:35 2003
> +++ src/sys/dev/pccbb/pccbb.c Wed Jun 11 20:37:28 2003
> @@ -1080,7 +1087,11 @@
> }
> if (sc->flags & CBB_CARD_OK) {
> STAILQ_FOREACH(ih, &sc->intr_handlers, entries) {
> + if ((ih->flags & INTR_MPSAFE) != 0)
> + mtx_lock(&Giant);
> (*ih->intr)(ih->arg);
> + if ((ih->flags & INTR_MPSAFE) != 0)
> + mtx_lock(&Giant);
> }
> }
> }
Isn't that second call supposed to be an unlock?
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030611225111.E42109>