Date: Tue, 21 Sep 2004 01:38:14 +0400 From: Roman Kurakin <rik@cronyx.ru> To: Nate Lawson <nate@root.org> Cc: John Baldwin <jhb@FreeBSD.org> Subject: Re: mp_machdep.c (was Re: [Fwd: Re: Bug reports requested - acpi]) Message-ID: <414F4DC6.9020509@cronyx.ru> In-Reply-To: <414F4CF2.2050404@root.org> References: <41421D6A.8070805@cronyx.ru> <414E7581.2070505@root.org> <414F256B.1030304@cronyx.ru> <200409201652.24457.jhb@FreeBSD.org> <414F4CF2.2050404@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Lawson: > John Baldwin wrote: > >> It's probably cleaner to use pmap_invalidate_range(). Something like: >> >> Index: mp_machdep.c >> =================================================================== >> RCS file: /usr/cvs/src/sys/i386/i386/mp_machdep.c,v >> retrieving revision 1.238 >> diff -u -r1.238 mp_machdep.c >> --- mp_machdep.c 1 Sep 2004 06:42:01 -0000 1.238 >> +++ mp_machdep.c 20 Sep 2004 20:50:35 -0000 >> @@ -738,15 +738,19 @@ >> int x; >> int size = *(int *) ((u_long) & bootMP_size); >> u_char *src = (u_char *) ((u_long) bootMP); >> - u_char *dst = (u_char *) boot_address + KERNBASE; >> + u_char *dst; >> u_int boot_base = (u_int) bootMP; >> u_int8_t *dst8; >> u_int16_t *dst16; >> u_int32_t *dst32; >> + vm_offset_t va; >> >> POSTCODE(INSTALL_AP_TRAMP_POST); >> >> - pmap_kenter(boot_address + KERNBASE, boot_address); >> + va = boot_address + KERNBASE; >> + pmap_kenter(va, boot_address); >> + pmap_invalidate_range(kernel_pmap, va, va + size); >> + dst = (u_char *)va; >> for (x = 0; x < size; ++x) >> *dst++ = *src++; >> >> It seems odd that this is needed though. Does it go away if you use >> DISABLE_PSE or DISABLE_PGE? > > He's on a Pentium 2 or something. Yes, it is PII. You want to tell that these settings shouldn't affect? (I don't know much about these features.) rik
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?414F4DC6.9020509>