Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Sep 2018 09:45:05 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Glen Barber <gjb@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r338653 - head/contrib/ofed/infiniband-diags/src
Message-ID:  <201809131645.w8DGj5RS095098@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201809131641.w8DGfFA2015938@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: gjb
> Date: Thu Sep 13 16:41:15 2018
> New Revision: 338653
> URL: https://svnweb.freebsd.org/changeset/base/338653
> 
> Log:
>   Remove __DATE__ and __TIME__ from ibdiag_common.c, replacing with
>   the hard-coded string "not available" to ensure reproducible builds.

Remove the "replacing with...." it was changed to remove the
__DATE__ and __TIME__ and replace it with nothing,
this is a simple mistake as the patch evolved over a few emails.

>   
>   Discussed with:	emaste
>   Approved by:	re (rgrimes)
>   Sponsored by:	The FreeBSD Foundation
> 
> Modified:
>   head/contrib/ofed/infiniband-diags/src/ibdiag_common.c
> 
> Modified: head/contrib/ofed/infiniband-diags/src/ibdiag_common.c
> ==============================================================================
> --- head/contrib/ofed/infiniband-diags/src/ibdiag_common.c	Thu Sep 13 16:27:21 2018	(r338652)
> +++ head/contrib/ofed/infiniband-diags/src/ibdiag_common.c	Thu Sep 13 16:41:15 2018	(r338653)
> @@ -84,8 +84,7 @@ static const struct ibdiag_opt *opts_map[256];
>  
>  static const char *get_build_version(void)
>  {
> -	return "BUILD VERSION: " IBDIAG_VERSION " Build date: " __DATE__ " "
> -	    __TIME__;
> +	return "BUILD VERSION: " IBDIAG_VERSION;
>  }
>  
>  static void pretty_print(int start, int width, const char *str)
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201809131645.w8DGj5RS095098>