Date: Fri, 04 Dec 2009 12:45:06 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r200055 - head/sys/netinet/ipfw Message-ID: <ygeiqcnqu65.wl%ume@mahoroba.org> In-Reply-To: <20091203193619.J83957@maildrop.int.zabbadoz.net> References: <200912031116.nB3BGsm2091411@svn.freebsd.org> <20091203193619.J83957@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
>>>>> On Thu, 3 Dec 2009 19:43:33 +0000 (UTC)
>>>>> "Bjoern A. Zeeb" <bz@FreeBSD.org> said:
bz> Does it need to be 48 rather than 46? You do not have the [] here.
bz> If not INET6_ADDRSTRLEN is what we use elsewhere. I would actually
bz> prefer to only have
bz> #ifdef INET6
bz> char src[INET6_ADDRSTRLEN|48], ..
bz> #else
bz> char src[INET_ADDRSTRLEN|18], ..
bz> #endif
bz> as it's 60 bytes of stack size for people w/o INET6 support (shame on
bz> them;-) Some applies for equivalent code further down.
Oops, I'll fix it later.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygeiqcnqu65.wl%ume>