Date: Fri, 22 Sep 2017 05:36:21 +0000 From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D12453: mbuf: Remove UDP_IPV4_EX, which is never defined. Message-ID: <differential-rev-PHID-DREV-6kyidkqupmcyjfhm6yfd-req@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
sepherosa_gmail.com created this revision.
REVISION SUMMARY
Add comment to explain the IPV6_EX suffix. The confusion about
these RSS hash type probably stems from the facts that they were
never widely implemented by hardwares.
REVISION DETAIL
https://reviews.freebsd.org/D12453
AFFECTED FILES
sys/sys/mbuf.h
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, rwatson, adrian, gallatin, freebsd-net-list, glebius
[-- Attachment #2 --]
diff --git a/sys/sys/mbuf.h b/sys/sys/mbuf.h
--- a/sys/sys/mbuf.h
+++ b/sys/sys/mbuf.h
@@ -335,6 +335,16 @@
* for ordering and distribution without explicit affinity. Additionally,
* M_HASHTYPE_OPAQUE_HASH indicates that the flow identifier has hash
* properties.
+ *
+ * The meaning of the IPV6_EX suffix:
+ * "o Home address from the home address option in the IPv6 destination
+ * options header. If the extension header is not present, use the Source
+ * IPv6 Address.
+ * o IPv6 address that is contained in the Routing-Header-Type-2 from the
+ * associated extension header. If the extension header is not present,
+ * use the Destination IPv6 Address."
+ * Quoted from:
+ * https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex
*/
#define M_HASHTYPE_HASHPROP 0x80 /* has hash properties */
#define M_HASHTYPE_HASH(t) (M_HASHTYPE_HASHPROP | (t))
@@ -348,14 +358,12 @@
* ext hdrs */
#define M_HASHTYPE_RSS_TCP_IPV6_EX M_HASHTYPE_HASH(6) /* TCPv6 4-tuple +
* ext hdrs */
-/* Non-standard RSS hash types */
#define M_HASHTYPE_RSS_UDP_IPV4 M_HASHTYPE_HASH(7) /* IPv4 UDP 4-tuple*/
-#define M_HASHTYPE_RSS_UDP_IPV4_EX M_HASHTYPE_HASH(8) /* IPv4 UDP 4-tuple +
- * ext hdrs */
#define M_HASHTYPE_RSS_UDP_IPV6 M_HASHTYPE_HASH(9) /* IPv6 UDP 4-tuple*/
#define M_HASHTYPE_RSS_UDP_IPV6_EX M_HASHTYPE_HASH(10)/* IPv6 UDP 4-tuple +
* ext hdrs */
+/* Non-standard RSS hash types */
#define M_HASHTYPE_OPAQUE 63 /* ordering, not affinity */
#define M_HASHTYPE_OPAQUE_HASH M_HASHTYPE_HASH(M_HASHTYPE_OPAQUE)
/* ordering+hash, not affinity*/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?differential-rev-PHID-DREV-6kyidkqupmcyjfhm6yfd-req>