Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 21 Jul 2011 12:14:26 +0200
From:      Attilio Rao <attilio@freebsd.org>
To:        Pan Tsu <inyaoo@gmail.com>, Sean Bruno <seanbru@yahoo-inc.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r224217 - in head/sys: amd64/include ia64/include mips/conf sys
Message-ID:  <CAJ-FndB5m5%2BzxO=5eyKXBdzHiSPBDGoSPeXNTkp1fdB3EQZZ3A@mail.gmail.com>
In-Reply-To: <86zkk8pqrn.fsf@gmail.com>
References:  <201107191300.p6JD0UU7073447@svn.freebsd.org> <86zkk8pqrn.fsf@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
2011/7/20 Pan Tsu <inyaoo@gmail.com>:
> Attilio Rao <attilio@FreeBSD.org> writes:
>
>> Author: attilio
>> Date: Tue Jul 19 13:00:30 2011
>> New Revision: 224217
>> URL: http://svn.freebsd.org/changeset/base/224217
>>
>> Log:
>> =C2=A0 Bump MAXCPU for amd64, ia64 and XLP mips appropriately.
>> =C2=A0 From now on, default values for FreeBSD will be 64 maxiumum suppo=
rted
>> =C2=A0 CPUs on amd64 and ia64 and 128 for XLP. All the other architectur=
es
>> =C2=A0 seem already capped appropriately (with the exception of sparc64 =
which
>> =C2=A0 needs further support on jalapeno flavour).
>>
>> =C2=A0 Bump __FreeBSD_version in order to reflect KBI/KPI brekage introd=
uced
>> =C2=A0 during the infrastructure cleanup for supporting MAXCPU > 32. Thi=
s
>> =C2=A0 covers cpumask_t retiral too.
>>
>> =C2=A0 The switch is considered completed at the present time, so for wh=
atever
>> =C2=A0 bug you may experience that is reconducible to that area, please =
report
>> =C2=A0 immediately.
>>
>> =C2=A0 Requested by: =C2=A0 =C2=A0 =C2=A0 marcel, jchandra
>> =C2=A0 Tested by: =C2=A0pluknet, sbruno
>> =C2=A0 Approved by: =C2=A0 =C2=A0 =C2=A0 =C2=A0re (kib)
>>
>> Modified:
>> =C2=A0 head/sys/amd64/include/param.h
>> =C2=A0 head/sys/ia64/include/param.h
>> =C2=A0 head/sys/mips/conf/XLP
>> =C2=A0 head/sys/mips/conf/XLP64
>> =C2=A0 head/sys/mips/conf/XLPN32
>> =C2=A0 head/sys/sys/param.h
>>
>> Modified: head/sys/amd64/include/param.h
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/sys/amd64/include/param.h =C2=A0 =C2=A0Tue Jul 19 12:41:57 2011=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r224216)
>> +++ head/sys/amd64/include/param.h =C2=A0 =C2=A0Tue Jul 19 13:00:30 2011=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r224217)
>> @@ -65,7 +65,7 @@
>>
>> =C2=A0#if defined(SMP) || defined(KLD_MODULE)
>> =C2=A0#ifndef MAXCPU
>> -#define MAXCPU =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 32
>> +#define MAXCPU =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 64
>> =C2=A0#endif
>> =C2=A0#else
>> =C2=A0#define MAXCPU =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1
>
> Do you plan to bump MEMSTAT_MAXCPU, too?
>
> =C2=A0$ vmstat -z
> =C2=A0vmstat: memstat_sysctl_uma: Too many CPUs
> =C2=A0$ vmstat -m
> =C2=A0vmstat: memstat_sysctl_malloc: Too many CPUs
>
> =C2=A0$ sysctl kern. | grep smp.\*cpus
> =C2=A0kern.smp.maxcpus: 64
> =C2=A0kern.smp.cpus: 2
>

Jeeeez, we seriously need to fix this getting rid of the static values.

Anyway, can you try the following patch?:
http://www.freebsd.org/~attilio/memstat_maxcpu.diff

It is going to add some memory overhead for i386 case.

Thanks,
Attilio


--=20
Peace can only be achieved by understanding - A. Einstein



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndB5m5%2BzxO=5eyKXBdzHiSPBDGoSPeXNTkp1fdB3EQZZ3A>