Date: Wed, 01 Jul 2009 11:52:26 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: svn-src-head@freebsd.org, dfr@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, bz0fbd@zabbadoz.net Subject: Re: svn commit: r195181 - in head/sys: nfsclient nfsserver Message-ID: <4A4B863A.7090304@FreeBSD.org> In-Reply-To: <20090630144904.GA41936@troutmask.apl.washington.edu> References: <200906300318.n5U3Ipr4066645@svn.freebsd.org> <20090630051641.T22887@maildrop.int.zabbadoz.net> <20090630144904.GA41936@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Steve Kargl wrote: > On Tue, Jun 30, 2009 at 05:17:48AM +0000, bz0fbd@zabbadoz.net wrote: >> On Tue, 30 Jun 2009, John Baldwin wrote: >> >>> Author: jhb >>> Date: Tue Jun 30 03:18:51 2009 >>> New Revision: 195181 >>> URL: http://svn.freebsd.org/changeset/base/195181 >>> >>> Log: >>> Fix build with NFS_LEGACYRPC enabled after the socket upcall locking >>> changes. >> is this really a good idea, considering that NFS_LEGACYRPC is on the >> "removal list" for 8.0? > > Yes. > > 1) This option definitely worked on April 18th. > 2) The option was broken by a commit that was never tested! If anything > this should remind committers to either get a code review or test > their patch. That isn't a completely fair assessment. The patch was most certainly tested with NFS in the default configuration (!NFS_LEGACYRPC). It is also a good idea to fix the option until such time as it is formally removed, however. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A4B863A.7090304>