Date: Fri, 24 Sep 2010 07:14:13 +0100 From: Rui Paulo <rpaulo@freebsd.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r213002 - in stable/8: include lib/libc/gen Message-ID: <3CC9503B-35BA-4637-8909-CBC6674ACDDA@freebsd.org> In-Reply-To: <20100923070247.L716@delplex.bde.org> References: <201009221800.o8MI0Ze3038214@svn.freebsd.org> <20100923070247.L716@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 22 Sep 2010, at 22:08, Bruce Evans wrote:
> On Wed, 22 Sep 2010, Rui Paulo wrote:
>=20
>> Log:
>> MFC r197804 (rwatson):
>> Add basename_r(3) to complement basename(3). basename_r(3) which =
accepts
>> a caller-allocated buffer of at least MAXPATHLEN, rather than using =
a
>> global buffer.
>=20
> MAXPATHLEN has been deprecated for more than 20 years. Please don't =
use
> it in new interfaces. A few man pages, not including basename.3, have
> been updated to spell it PATH_MAX (should be {PATH_MAX}).
I'm not going to fix this because the interface will most likely change =
to something that doesn't require PATH_MAX. But thanks for pointing this =
out.
>=20
>> Note about semantics: while this interface is not POSIXy, there's
>> another major platform that uses it (Android) and the semantics =
between
>> the two platforms are pretty much the same.
>=20
> It is also not non-POSIX...
>=20
>> Modified: stable/8/include/libgen.h
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- stable/8/include/libgen.h Wed Sep 22 16:54:22 2010 =
(r213001)
>> +++ stable/8/include/libgen.h Wed Sep 22 18:00:34 2010 =
(r213002)
>> @@ -36,6 +36,7 @@
>> __BEGIN_DECLS
>>=20
>> char *basename(const char *);
>> +char *basename_r(const char *, char *);
>> char *dirname(const char *);
>> #if 0
>> char *regcmp(const char *, ...);
>>=20
>=20
> ...since it is declared in the POSIX namespace.
I don't know of a better place to declare it.
Regards,
--
Rui Paulo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CC9503B-35BA-4637-8909-CBC6674ACDDA>