Date: Mon, 7 Nov 2005 17:51:31 -0500 From: John Baldwin <jhb@freebsd.org> To: Scott Long <scottl@samsco.org> Cc: Rink Springer <rink@stack.nl>, ed@fxq.nl, freebsd-arch@freebsd.org Subject: Re: FreeBSD/xbox: updated 7.0 patchset Message-ID: <200511071751.32609.jhb@freebsd.org> In-Reply-To: <436FD47D.2000802@samsco.org> References: <20051106222359.GC46752@stack.nl> <200511071635.39323.jhb@freebsd.org> <436FD47D.2000802@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 07 November 2005 05:26 pm, Scott Long wrote: > John Baldwin wrote: > > On Monday 07 November 2005 02:44 pm, Rink Springer wrote: > >>Hi, > >> > >>OK, I've updated the patchset. Changes: > >> > >>- opt_xbox.h is now used instead of opt_global.h > >>- xboxfb.c should follow style(9) better > >>- boot_font.c is no longer patched > >>- 128MB XBOX-es should work too [1] > >> > >>It is fetchable from > >>http://rink.nu/downloads/xbox-patches/xbox-7-current.v2.diff > >> > >>Oh, and for John's comment: The reason pic16l.s is coded in assembly, was > >>that it was used extensively while debugging (it even resided in > >>locore.s for a while :-), as being able to change the LED's color is > >>immensely useful if you don't have a framebuffer working already :) This > >>is why I'd prefer to keep this file as-is. > > > > You do realize that you can call C functions from assembly, right? :) > > If this is the only remaining technical objection, then can it be > something that gets resolved after it goes into the tree? It's code > that is segregated and private to the XBOX port, so it would be a shame > to make it stall this great work. Yes, certainly, that is only a minor nit! I just tend to prefer that we keep as much code in C as possible rather than asm as C has a lower learning curve. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511071751.32609.jhb>