Date: Fri, 19 Mar 2021 21:25:35 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: "Scheffenegger, Richard" <Richard.Scheffenegger@netapp.com>, "tuexen@freebsd.org" <tuexen@freebsd.org> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, Alexander Motin <mav@FreeBSD.org> Subject: Re: NFS Mount Hangs Message-ID: <YQXPR0101MB09682FED1BE7519D4D2FA39EDD689@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <SN4PR0601MB37287E24D3CFF470C60724F886689@SN4PR0601MB3728.namprd06.prod.outlook.com> References: <C643BB9C-6B61-4DAC-8CF9-CE04EA7292D0@tildenparkcapital.com> <3750001D-3F1C-4D9A-A9D9-98BCA6CA65A4@tildenparkcapital.com> <33693DE3-7FF8-4FAB-9A75-75576B88A566@tildenparkcapital.com> <YQXPR0101MB0968DC18E00833DE2969C636DD6A9@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> <SN4PR0601MB3728780CE9ADAB144B3B681486699@SN4PR0601MB3728.namprd06.prod.outlook.com> <2890D243-AF46-43A4-A1AD-CB0C3481511D@lurchi.franken.de> <YQXPR0101MB0968D2362456D43DF528A7E9DD699@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> <9EE3DFAC-72B0-4256-B57C-DE6AA811413C@freebsd.org> <YQXPR0101MB0968E1537E26CDBDC31C58E5DD689@YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM> <SN4PR0601MB372895EE1F6DDFA830D4B7AC86689@SN4PR0601MB3728.namprd06.prod.outlook.com> <03DE00F1-B60D-49AE-AC53-C83BA9F0F5C7@freebsd.org>, <SN4PR0601MB37287E24D3CFF470C60724F886689@SN4PR0601MB3728.namprd06.prod.outlook.com>
index | next in thread | previous in thread | raw e-mail
Scheffenegger, Richard <Richard.Scheffenegger@netapp.com> wrote: >Sorry, I though this was a problem on stable/13. > >This is only in HEAD, stable/13 and 13.0 - never MFC'd to stable/12 or backported to >12.1 > >> I did some reshuffling of socket-upcalls recently in the TCP stack, to prevent some race conditions with our $work in-kernel NFS server implementation. The FreeBSD krpc/nfs definitely uses upcalls. On the server side the upcall just "activates" a thread to service the socket (soreceive() etc). The client side upcall does quite a bit more, including soreceive(). Timing shouldn't be a problem, so long as upcalls happen when there is data to be received or the socket has been closed at the other end. I test with pretty current sources and haven't seen issues. If I do see problems, I'll be sure to let you know.;-) rick Are these changes in 12.1p5? This is the OS version used by the reporter of the bug. Best regards Michaelhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQXPR0101MB09682FED1BE7519D4D2FA39EDD689>