Date: Sun, 21 Mar 2004 11:54:05 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: David O'Brien <obrien@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/gcc34 Makefile Message-ID: <Pine.BSF.4.58.0403211135080.41186@acrux.dbai.tuwien.ac.at> In-Reply-To: <20040320195311.GB89343@dragon.nuxi.com> References: <200403170818.i2H8IFYU008824@repoman.freebsd.org> <Pine.BSF.4.58.0403171036060.94079@acrux.dbai.tuwien.ac.at> <Pine.BSF.4.58.0403171135480.94079@acrux.dbai.tuwien.ac.at> <20040317182432.GA96023@dragon.nuxi.com> <Pine.BSF.4.58.0403190206360.94079@acrux.dbai.tuwien.ac.at> <20040320195311.GB89343@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 20 Mar 2004, David O'Brien wrote:
> Actually this is a bug in your pkg-plist. I just tested this with your
> latest commits (Makefile rev 1.166, pkg-plist rev 1.55). This patch
> (which I just committed) makes the existing breakage obvious:
>
> @dirrm libexec/gcc/%%GNU_HOST%%/%%GCC_VER%%
> +@dirrm libexec/gcc/%%GNU_HOST%%
> +@dirrm libexec/gcc
> %%LIBJAVA%%share/java/libgcj-%%GCC_VER%%.jar
Won't this break if more than gcc3x port has been installed? (I'll
shortly mark them as CONFLICTing, but in the longer term this should
work.)
> If you look at ports/Mk/bsd.port.mk, you'll see that CONFIGURE_TARGET is
> defined as ${MACHINE_ARCH}-portbld-freebsd${OSREL}, which is effectively
> the same as the definition I removed and you re-added.
I know that, and in fact I had tried something similar to your original
patch a few weeks ago. :-> That's why I immediately got alerted when
seeing your patch.
> Can we agree to this patch now?
>
> .if ${ARCH} == "amd64"
> CONFIGURE_TARGET= x86_64-portbld-freebsd${OSREL}
> -.else
> -CONFIGURE_TARGET= ${ARCH}-portbld-freebsd${OSREL}
> .endif
Sure, iff it survives full testing (including a `make deinstall` that
really removes all files installed by the port).
Gerald
--
Gerald Pfeifer (Jerry) gerald@pfeifer.com http://www.pfeifer.com/gerald/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.58.0403211135080.41186>