Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 3 Dec 2013 22:26:38 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r258897 - in head/contrib/llvm/tools/lldb/source: Breakpoint Symbol
Message-ID:  <201312032226.rB3MQcJ4019604@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: emaste
Date: Tue Dec  3 22:26:38 2013
New Revision: 258897
URL: http://svnweb.freebsd.org/changeset/base/258897

Log:
  Update LLDB to upstream r196322 snapshot
  
  Upstream revisions of note:
  r196298 - Fix use of std::lower_bound
  r196322 - Fix log message for new invalidation checks
  
  Sponsored by:	DARPA, AFRL

Modified:
  head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp
  head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp
Directory Properties:
  head/contrib/llvm/tools/lldb/   (props changed)

Modified: head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp
==============================================================================
--- head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp	Tue Dec  3 22:16:33 2013	(r258896)
+++ head/contrib/llvm/tools/lldb/source/Breakpoint/BreakpointLocationList.cpp	Tue Dec  3 22:26:38 2013	(r258897)
@@ -86,16 +86,13 @@ Compare (BreakpointLocationSP lhs, lldb:
 BreakpointLocationSP
 BreakpointLocationList::FindByID (lldb::break_id_t break_id) const
 {
-    BreakpointLocationSP bp_loc_sp;
     Mutex::Locker locker (m_mutex);
-    
-    collection::const_iterator begin = m_locations.begin(), end = m_locations.end();
-    collection::const_iterator result;
-    result = std::lower_bound(begin, end, break_id, Compare);
-    if (result == end)
-        return bp_loc_sp;
+    collection::const_iterator end = m_locations.end();
+    collection::const_iterator pos = std::lower_bound(m_locations.begin(), end, break_id, Compare);
+    if (pos != end && (*pos)->GetID() == break_id)
+        return *(pos);
     else
-        return *(result);
+        return BreakpointLocationSP();
 }
 
 size_t

Modified: head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp
==============================================================================
--- head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp	Tue Dec  3 22:16:33 2013	(r258896)
+++ head/contrib/llvm/tools/lldb/source/Symbol/UnwindPlan.cpp	Tue Dec  3 22:26:38 2013	(r258897)
@@ -379,7 +379,19 @@ UnwindPlan::PlanValidAtAddress (Address 
     {
         Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_UNWIND));
         if (log)
-            log->Printf ("Testing if UnwindPlan is valid at pc 0x%" PRIx64 ": No unwind rows - is invalid.");
+        {
+            StreamString s;
+            if (addr.Dump (&s, NULL, Address::DumpStyleSectionNameOffset))
+            {
+                log->Printf ("UnwindPlan is invalid -- no unwind rows for UnwindPlan '%s' at address %s",
+                             m_source_name.GetCString(), s.GetData());
+            }
+            else
+            {
+                log->Printf ("UnwindPlan is invalid -- no unwind rows for UnwindPlan '%s'",
+                             m_source_name.GetCString());
+            }
+        }
         return false;
     }
 
@@ -389,7 +401,19 @@ UnwindPlan::PlanValidAtAddress (Address 
     {
         Log *log(GetLogIfAllCategoriesSet (LIBLLDB_LOG_UNWIND));
         if (log)
-            log->Printf ("Testing if UnwindPlan is valid at pc 0x%" PRIx64 ": No CFA register - is invalid.");
+        {
+            StreamString s;
+            if (addr.Dump (&s, NULL, Address::DumpStyleSectionNameOffset))
+            {
+                log->Printf ("UnwindPlan is invalid -- no CFA register defined in row 0 for UnwindPlan '%s' at address %s",
+                             m_source_name.GetCString(), s.GetData());
+            }
+            else
+            {
+                log->Printf ("UnwindPlan is invalid -- no CFA register defined in row 0 for UnwindPlan '%s'",
+                             m_source_name.GetCString());
+            }
+        }
         return false;
     }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312032226.rB3MQcJ4019604>