Date: Wed, 11 Aug 2010 16:34:30 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Will Andrews <will@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211157 - in head/sys: modules modules/if_carp net netinet netinet6 Message-ID: <20100811143430.GB1707@garage.freebsd.pl> In-Reply-To: <201008110051.o7B0pp10084996@svn.freebsd.org> References: <201008110051.o7B0pp10084996@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 11, 2010 at 12:51:51AM +0000, Will Andrews wrote: > Author: will > Date: Wed Aug 11 00:51:50 2010 > New Revision: 211157 > URL: http://svn.freebsd.org/changeset/base/211157 >=20 > Log: > Allow carp(4) to be loaded as a kernel module. Follow precedent set by > bridge(4), lagg(4) etc. and make use of function pointers and > pf_proto_register() to hook carp into the network stack. > =20 > Currently, because of the uncertainty about whether the unload path is = free > of race condition panics, unloads are disallowed by default. Compiling= with > CARPMOD_CAN_UNLOAD in CFLAGS removes this anti foot shooting measure. Wouldn't it be better to allow unload only if there are no carp(4) interfaces? I'd be glad to destroy my carp interfaces before unloading the module, but recompiling the kernel to unload it? Not so much. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gatW/ieO32f1wygP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkxitPYACgkQForvXbEpPzRqvQCgxjWVcEpk4G7Pu/peCL5TLmle pA8AoONGNVqKqiZeuuUzSttR5wIrUttB =+ySk -----END PGP SIGNATURE----- --gatW/ieO32f1wygP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100811143430.GB1707>