Date: Sat, 6 Mar 2004 17:33:50 +0300 (MSK) From: Dmitry Morozovsky <marck@rinet.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/63839: [patch] vinum fake-disklabel block/frag fix Message-ID: <200403061433.i26EXoZH012162@woozle.rinet.ru> Resent-Message-ID: <200403061440.i26EeBP9006852@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 63839
>Category: kern
>Synopsis: [patch] vinum fake-disklabel block/frag fix
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 06 06:40:11 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Morozovsky
>Release: FreeBSD 4-STABLE i386
>Organization:
Cronyx Plus LLC (RiNet ISP)
>Environment:
System: FreeBSD 4-STABLE
>Description:
This patch changes vinum fake-disklabel block/frag size from default 8k/1k to
more approppriate for modern disks 16k/2k. Also, it removes duplicate
assignment. It applies to both -current and -stable.
>How-To-Repeat:
Configure vinum volume
disklabel /dev/vinum/${volume}
Watch for values in 'a' partition.
>Fix:
Index: sys/dev/vinum/vinumio.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/vinum/vinumio.c,v
retrieving revision 1.52.2.6
diff -u -r1.52.2.6 vinumio.c
--- sys/dev/vinum/vinumio.c 2 May 2002 08:43:44 -0000 1.52.2.6
+++ sys/dev/vinum/vinumio.c 6 Mar 2004 14:18:23 -0000
@@ -750,9 +750,8 @@
* swap, c is nothing.
*/
lp->d_partitions[0].p_size = size;
- lp->d_partitions[0].p_fsize = 1024;
lp->d_partitions[0].p_fstype = FS_BSDFFS; /* FreeBSD File System :-) */
- lp->d_partitions[0].p_fsize = 1024; /* FS fragment size */
+ lp->d_partitions[0].p_fsize = 2048; /* FS fragment size */
lp->d_partitions[0].p_frag = 8; /* and fragments per block */
lp->d_partitions[SWAP_PART].p_size = size;
lp->d_partitions[SWAP_PART].p_fstype = FS_SWAP; /* swap partition */
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200403061433.i26EXoZH012162>