Date: Tue, 22 Jul 2003 15:52:28 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Gregory Neil Shapiro <gshapiro@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/sendmail Makefile Message-ID: <20030722125228.GC36151@sunbay.com> In-Reply-To: <200307100453.h6A4rXeH084564@repoman.freebsd.org> References: <200307100453.h6A4rXeH084564@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Jul 09, 2003 at 09:53:32PM -0700, Gregory Neil Shapiro wrote:
> gshapiro 2003/07/09 21:53:32 PDT
>
> FreeBSD src repository
>
> Modified files:
> etc/sendmail Makefile
> Log:
> Continue trying to build SENDMAIL_CF if the user uses SENDMAIL_CF
> instead of SENDMAIL_MC but don't remove on it 'make clean' as the
> user may not have the original .mc file and removing it could be
> dangerous (e.g., make SENDMAIL_CF=/etc/mail/sendmail.cf clean).
>
> Noticed by: peter
> MFC after: 3 days
>
> Revision Changes Path
> 1.26 +5 -2 src/etc/sendmail/Makefile
>
Gregory,
I have trouble understanding what this commit fixes. I have read
the preceding discussion where you explained to Peter that SENDMAIL_CF
should have a /full/path/to/sendmail.cf, but even after that it's
still unclear: just reverting to rev. 1.24 of etc/sendmail/Makefile
gives the below, which looks very consistent to me:
: Script started on Tue Jul 22 15:46:47 2003
: # ident Makefile
: Makefile:
: $FreeBSD: src/etc/sendmail/Makefile,v 1.24 2003/07/06 18:54:18 gshapiro Exp $
: # ls -l /etc/mail/sendmail.cf
: -r--r--r-- 1 root wheel 57028 Jul 22 15:02 /etc/mail/sendmail.cf
: # make -n clean SENDMAIL_CF=/etc/mail/sendmail.cf
: rm -f freebsd.cf
No attempts to remove /etc/mail/sendmail.cf.
: # make -n install SENDMAIL_CF=/etc/mail/sendmail.cf
No attempts to install the file over itself.
: # make -n install SENDMAIL_CF=/foo/bar/sendmail.cf
: install -o root -g wheel -m 644 /foo/bar/sendmail.cf /etc/mail/sendmail.cf
: # make -n clean SENDMAIL_CF=/foo/bar/sendmail.cf
: rm -f freebsd.cf
No attempts to remove /foo/bar/sendmail.cf, either.
: Script done on Tue Jul 22 15:47:47 2003
We weren't removing the ${SENDMAIL_CF} file because we weren't
adding it to the list of files to build (${ALL}) which we then
remove (CLEANFILES=${ALL}).
Can you please clarify this?
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE/HTOMUkv4P6juNwoRAhutAJ40MpeaAGTSOKV7qKoqQlhGPAL4hwCcDwCZ
sl9ca6lnbmCeSXkXg+dYm6g=
=OKcK
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030722125228.GC36151>