Date: Sun, 1 May 2005 13:10:05 GMT From: "Adam Kropelin" <akropel1@rochester.rr.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/80383: [PATCH] Add quirk for uhid to ignore certain usbdevices (blacklist) Message-ID: <200505011310.j41DA59P021794@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/80383; it has been noted by GNATS. From: "Adam Kropelin" <akropel1@rochester.rr.com> To: "Thierry Thomas" <thierry@freebsd.org>, "Lonnie Mendez" <lmendez19@austin.rr.com> Cc: <FreeBSD-gnats-submit@freebsd.org>, <freebsd-usb@freebsd.org> Subject: Re: kern/80383: [PATCH] Add quirk for uhid to ignore certain usbdevices (blacklist) Date: Sun, 1 May 2005 09:08:12 -0400 Thierry Thomas wrote: >> Le Mer 27 avr 05 à 7:55:31 +0200, Lonnie Mendez >> <lmendez19@austin.rr.com> écrivait : >>> >>>> Number: 80383 >>>> Category: kern >>>> Synopsis: [PATCH] Add quirk for uhid to ignore certain usb >>>> devices (blacklist) >> >>>> Description: >>> >>> This patch allows uhid to leave alone devices that identify >>> themselves as hid based, but are indeed >>> used via another interface. This is very simliar in concept to the >>> hid blacklist table found in hid-core.c in the linux kernel. >> >> Fine! I also need this to use the new MGE UPS devices (with nut, >> libusb and the newhidups driver). I have applied the submitted patch >> on a >> 5.4-STABLE, and it's OK. >> >> To add the MGE UPS devices, I need the attached patches. Just to nitpick a little... > +product MGE UPS1 0x0001 MGEUPS newhidups 1 > +product MGE UPS2 0xffff MGEUPS newhidups 2 I'm not sure it's appropriate in this context to refer to a userspace program like "newhidups". I think this field is really meant to be a textual name for the product being identified. Based on the other entries in the file, something like a model name or generc description may be more appropriate. --Adam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200505011310.j41DA59P021794>