Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Apr 2002 04:54:13 -0700 (PDT)
From:      David Wolfskill <david@catwhisker.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   bin/37036: Make "periodic" output show positive "end-of-report" info
Message-ID:  <200204131154.g3DBsDtx068757@d144.catwhisker.org>

next in thread | raw e-mail | index | archive | help

>Number:         37036
>Category:       bin
>Synopsis:       Make "periodic" output show positive "end-of-report" info
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 13 05:00:06 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     David Wolfskill
>Release:        FreeBSD 4.5-STABLE i386
>Organization:
Wolfskill & Dowling residence
>Environment:
System: FreeBSD d144.catwhisker.org 4.5-STABLE FreeBSD 4.5-STABLE #139: Fri Apr 12 06:07:26 PDT 2002 root@d144.catwhisker.org:/common/S1/obj/usr/src/sys/LAPTOP_30W i386


	Aplies equally well to -CURRENT.
>Description:
	The output from "periodic" is a collection of outputs from a
	variety of individual scripts.  As such, if the output were
	to be truncated for some reason, the recipient of the report
	could well fail to notice this.  While this could well be
	considered the responsibility of the recipient, there is a
	small thing we could do to make the recipient's life a little
	easier:  just add a line to indicate that "this is the end."
>How-To-Repeat:
	Check the output of "periodic".  For example, here's the tail
	end of the "security" output for my build machine:

freebeast.catwhisker.org login failures:

freebeast.catwhisker.org refused connections:


	My laptop, however, has received tghe below patch; here is its
	corresponding output:

d144.catwhisker.org login failures:

d144.catwhisker.org refused connections:

End of output from security


	Note that I'm not trying to do anything fancy here -- no crypto
	hashes, or anything like that.  Just a simple visual confirmation
	that the end of the report didn't drop off into the aether.
>Fix:

	The following works for me.  Please consider it as a suggestion
	-- season to taste:

cvs diff: Diffing usr.sbin/periodic
Index: usr.sbin/periodic/periodic.sh
===================================================================
RCS file: /cvs/freebsd/src/usr.sbin/periodic/periodic.sh,v
retrieving revision 1.9.2.7
diff -u -r1.9.2.7 periodic.sh
--- usr.sbin/periodic/periodic.sh	26 Nov 2000 06:06:18 -0000	1.9.2.7
+++ usr.sbin/periodic/periodic.sh	11 Apr 2002 22:53:57 -0000
@@ -97,6 +97,9 @@
         then
           [ $processed = 1 ] && plural= || plural=s
           echo "No output from the $processed file$plural processed"
+	else
+	  echo ""
+	  echo "End of output from ${arg}"
         fi
     } | eval $pipe
 done
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204131154.g3DBsDtx068757>