Date: Tue, 21 Jan 2014 13:19:01 -0500 From: John Baldwin <jhb@freebsd.org> To: Ruslan Makhmatkhanov <cvs-src@yandex.ru> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r260926 - in head: sys/dev/pci sys/sys usr.sbin/pciconf Message-ID: <201401211319.02050.jhb@freebsd.org> In-Reply-To: <52DEB336.1040306@yandex.ru> References: <201401202056.s0KKuAbH069433@svn.freebsd.org> <201401211100.25712.jhb@freebsd.org> <52DEB336.1040306@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, January 21, 2014 12:49:42 pm Ruslan Makhmatkhanov wrote: > John Baldwin wrote on 21.01.2014 20:00: > > On Monday, January 20, 2014 3:56:10 pm John Baldwin wrote: > >> Author: jhb > >> Date: Mon Jan 20 20:56:09 2014 > >> New Revision: 260926 > >> URL: http://svnweb.freebsd.org/changeset/base/260926 > >> > >> Log: > >> Add support for displaying VPD for PCI devices via pciconf. > >> - Store the length of each read-only VPD value since not all values are > >> guaranteed to be ASCII values (though most are). > >> - Add a new pciio ioctl to fetch VPD for a single PCI device. The values > >> are returned as a list of variable length records, one for the device > >> name and each keyword. > >> - Add a new -V flag to pciconf's list mode which displays VPD data for > >> each device. > >> > >> MFC after: 1 week > > > > Sample output: > > > > t4nex0@pci0:4:0:4: class=0x020000 card=0x00001425 chip=0x44011425 > > rev=0x00 hdr=0x00 > > VPD ident = 'T420-LL-CR ' > > VPD ro PN = '110114640C0 ' > > VPD ro EC = '01234567890123 ' > > VPD ro SN = 'PT06120042 ' > > VPD ro NA = '000743123340' > > VPD ro V0 = '0909FFFF' > > VPD ro V1 = '48000810180109111948484848484847' > > ... > > That's great. So why not to strip whitespace in the output? I suppose it could trim trailing whitespace. The format of these fields is very loose (just ASCII), so I wanted to display the raw value in case there were cases where it might be significant. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401211319.02050.jhb>