Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Dec 2020 17:42:29 +0100
From:      Michal Meloun <meloun.michal@gmail.com>
To:        Marcel Flores <marcel@brickporch.com>
Cc:        freebsd-arm <freebsd-arm@freebsd.org>
Subject:   Re: ThunderX Panic after r368370
Message-ID:  <6c5ebe94-561d-7166-1443-c245dc326249@freebsd.org>
In-Reply-To: <3765F708-15A9-4CB0-96A6-5534E0A9F3DE@brickporch.com>
References:  <1C3442ED-278E-45B8-9206-0DD24FCBC237@brickporch.com> <4331eee0-74a6-565c-3bec-0051415b2bc1@freebsd.org> <56F0E9EB-0B78-4B0B-830A-48F8AFC5ABE1@yahoo.com> <91654fc4-8734-d8a7-5309-0400f418438a@freebsd.org> <BB5C4C3E-EDF6-4C3D-BEE1-F8B2989216E0@yahoo.com> <4528E502-D007-48E5-B6A5-8E4376A2B05E@yahoo.com> <0ea700bd-d31c-f6c9-59f3-d3b3bbbd5775@freebsd.org> <3765F708-15A9-4CB0-96A6-5534E0A9F3DE@brickporch.com>

next in thread | previous in thread | raw e-mail | index | archive | help


On 07.12.2020 17:33, Marcel Flores wrote:
> 
>> On Dec 7, 2020, at 1:13 AM, Michal Meloun <meloun.michal@gmail.com> wrote:
>>
>> On 07.12.2020 9:21, Mark Millard wrote:
>>> On 2020-Dec-6, at 13:30, Mark Millard <marklmi at yahoo.com> wrote:
>>>> On 2020-Dec-6, at 03:51, Michal Meloun <meloun.michal at gmail.com> wrote:
>>>>
>>>> On 06.12.2020 10:47, Mark Millard wrote:
>>>>>> On 2020-Dec-6, at 00:17, Michal Meloun <meloun.michal at gmail.com> wrote:
>>>>>>> On 06.12.2020 3:21, Marcel Flores wrote:
>>>>>>>> Hi All,
>>>>>>>> Looks like the ThunderX started panicking at boot after r368370:
>>>>>>>> https://reviews.freebsd.org/rS368370
>>>>>>>>  From a verbose boot, it looks like it bails in gic0 redistributor setup(?):
>>>>>>>> gic0: CPU29 Re-Distributor woke up
>>>>>>>> gic0: CPU24 enabled CPU interface via system registers
>>>>>>>> gic0: CPU17 enabled CPU interface via system registers
>>>>>>>> gic0: CPU29 enabled CPU interface via system registers
>>>>>>>> done
>>> Looks to me like fdt_cpuid's use in cpu_init_fdt is one of the issues
>>> with what is added to each cpuset_domain[domain] :
>>> fdt_cpuid's initial value can not be added by this code: it is
>>> incremented first.
>>
>> Good catch. This ThunderX system is *FDT* based. And I spend half of night by digging in ACPI sources in attempt to understand who screw cpuset_domain :P
>>
>> Marcel, can you please try following patch? I hope that it fix this issue.
>>
>> https://github.com/strejda/freebsd/commit/1404960be6a7a6c75af86e86331acf951cfdf9b1
>>
> 
> That did the trick — no more panic.
> 
> Working debug-patch output just in case:
> 
> https://gist.github.com/mesflores/be330f23df2faa93a082825104b986a1
> 
> Appreciate the quick response!
> 

In meantime, Andrew made expanded version of this fix
https://reviews.freebsd.org/D27497

I sure that this will be committed ASAP.
Many thanks for cooperation and help. Sorry for troubles.
Michal



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6c5ebe94-561d-7166-1443-c245dc326249>