Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 18 Apr 2021 23:47:40 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 255202] drawer.lua: brand positioning not working
Message-ID:  <bug-255202-227@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255202

            Bug ID: 255202
           Summary: drawer.lua: brand positioning not working
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: bugs@FreeBSD.org
          Reporter: jlduran@gmail.com
                CC: kevans@freebsd.org, tsoome@freebsd.org

Created attachment 224233
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224233&action=
=3Dedit
Screenshot with spindle artifact

drawer.lua ignores the values in `loader_brand_x` and `loader_brand_y`.

I have attached a patch that *fixes* it, but I would like to request, if
possible, some reviewing.

I have also attached a screenshot, taken with the patch applied, however
there's the spindle? artifact hanging around, and being shifted by the
offsetting of the brand (indicated by the red arrow). I don't know how to
address this.

This can be replicated by creating two files:

/boot/loader.conf.d/bootloader.conf:
loader_logo=3D"none"
loader_brand=3D"nakatomi"
loader_brand_x=3D"15"

/boot/lua/gfx-nakatomi.lua:
return {
        brand =3D {
                image =3D "/boot/images/freebsd-logo-rev.png"
        }
}

Thank you!

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255202-227>