Date: Sat, 31 Dec 2016 12:55:08 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Michael Butler <imb@protected-networks.net> Cc: ngie@freebsd.org, freebsd-current <freebsd-current@freebsd.org> Subject: Re: SVN r310931 Bad code Message-ID: <69688AC6-02E3-4C71-8214-22F2951F8C62@gmail.com> In-Reply-To: <742de824-6f35-8c91-8603-c5a766e313b4@protected-networks.net> References: <742de824-6f35-8c91-8603-c5a766e313b4@protected-networks.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Dec 31, 2016, at 06:14, Michael Butler <imb@protected-networks.net> wrote:
>
> At line 1949 of head/contrib/bsnmp/lib/snmpclient.c, you changed ..
>
> - if ((sc->chost = malloc(strlen(s) + 1)) == NULL) {
> + if ((sc->chost = strdup(strlen(s))) == NULL) {
>
> This can't work as intended since strlen returns the length of the
> string not a pointer to it.
>
> I expect this should be ..
>
> if ((sc->chost = strdup(s)) == NULL) {
Yeah… egg on my face... I fixed it in r310942.
Sorry for the breakage :/…
-Ngie
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJYaBstAAoJEPWDqSZpMIYVbwsP/j+O0na1i9wrGmR28kkDIfYq
vQDaj5/vUctFjjgOUMYd0LwlDmNkPsYD92Hq2YE2RivCxQ2liZ+b2wwSZCuVPCtp
EQWtj5S+21ujGYQj/gFyG6Vx+1VbaJfmxG4eguS7KbaYIWmCD2KHI5wAhOmAwPYH
VBb3fjbhcogiBVsGzJ5qAroBTvvreBtzdGS38sZXoS0uF52Hjz2iRl6zGojRyjqf
R9EKRSXhB7WiG1ZMuCps0vtxnm4ZMYTShEOw9xuHmAsCeHBBx1jb4iO9C9Jkp38E
L59c25vdgD8pbqMAehWZHeo4aZIwI74EJjnNR9FAfn+CYEuQT8tEi7MNq1ro52HH
QGI3FvPSiGdEWssBIUgZI8wONoxt8yKM5hDqr/IUZY62d0TXxMHrp84nim2bgq47
kcBRAt1+35HiwE98Hus1VPnwwj+jbIRxd/oC2FmsMsW5OLJCoDp61gJk2rt8PpbU
etZ4FABpQOQjFWiSnRXHPM6XXp2HPsAu56mAiaE9BUzBZGWloFVpOiBGcL9YUofP
WruBkB/1nlbHouzRJmfwTp3dlNlLKY4f5U2bxCW27x/xyrWD0pMOir+6Bvo7yzFx
TxGxugYmYFtYgk6Ip8M6K/gq68jPLRwAKy8X29MAemmAtpNunDF9H8ezn9WMrQcO
UYLJEaUtIrTFiMk+mjZX
=HnpP
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69688AC6-02E3-4C71-8214-22F2951F8C62>