Date: Thu, 31 Dec 1998 16:00:06 +0800 From: Peter Wemm <peter@netplex.com.au> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: committers@FreeBSD.ORG Subject: Re: ES1370 audio driver -- where do i put it ? Message-ID: <199812310800.QAA90152@spinner.netplex.com.au> In-Reply-To: Your message of "Thu, 31 Dec 1998 06:43:20 %2B0100." <199812310543.GAA19458@labinfo.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo wrote: > The recent commits to the pcm driver were meant to integrate Joackim's > driver for ES1370-based cards. > > Being a PCI card i'd put the relevant files (es1370.c and > es1370_reg.h) in /sys/pci; however, at the moment this is a > i386-specific piece of code (although it used absolutely no ISA > functionality so chances are that it works with minor fixes on the > Alpha as well). So, is the location ok, or perhaps it should go in > /sys/i386/isa/snd with the other "pcm" files ? Well, on the offchance that the sound code that is currently in the isa directories becomes portable to ISA busses in general, having the PCI driver already in sys/pci would mean one less file to copy or reorganize. Also, there is a precedent: sys/i386/isa/if_ed* and sys/pci/if_ed_p.c (the pci glue). So, stick it in sys/pci unless there's absolutely zero chance that it'll ever be used on something other than i386. Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199812310800.QAA90152>